hg: jdk8/tl: 7132204: Default testset in JPRT should not run all tests

Changeset: 0f653ee93477 Author:alanb Date: 2012-01-24 09:08 + URL: http://hg.openjdk.java.net/jdk8/tl/rev/0f653ee93477 7132204: Default testset in JPRT should not run all tests Reviewed-by: ohair ! make/jprt.properties

hg: jdk8/tl/jdk: 7132204: Default testset in JPRT should not run all tests

Changeset: 237319a01a9a Author:alanb Date: 2012-01-24 09:09 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/237319a01a9a 7132204: Default testset in JPRT should not run all tests Reviewed-by: ohair ! make/jprt.properties ! test/ProblemList.txt

Re: RFR: 7131399: Poll system call appears to be broken on Mac OS [macosx]

I'm OK with this as it, but here are a few comments: The logic around the initial setting of the timeout seems a little unnecessary (and the additional pointer), but not wrong. The comments should also be updated. Given this problem should the build be setting USE_SELECT? -Chris. On 01/23/1

Re: RFR: 7131399: Poll system call appears to be broken on Mac OS [macosx]

On 24/01/12 10:23, Chris Hegarty wrote: I'm OK with this as it, but here are a few comments: The logic around the initial setting of the timeout seems a little unnecessary (and the additional pointer), but not wrong. Chris, The setting of the timeval could be combined ok, but I wanted to av

Re: RFR: 7131399: Poll system call appears to be broken on Mac OS [macosx]

Thanks the explanations. As I said, I'm fine with the change as is. -Chris. On 01/24/12 10:41 AM, Michael McMahon wrote: On 24/01/12 10:23, Chris Hegarty wrote: I'm OK with this as it, but here are a few comments: The logic around the initial setting of the timeout seems a little unnecessary

Re: RFR: 7131399: Poll system call appears to be broken on Mac OS [macosx]

On 23/01/2012 22:32, Michael McMahon wrote: No, I don't think so. fd_sets are bit masks and you have to specify the highest numbered bit in the mask (+1). Sorry, I wasn't thinking, it's nfds+1. In that case, I think the change is okay although having t, t1, and t1_p looks a bit messy. It migh

Re: RFR: 7131399: Poll system call appears to be broken on Mac OS [macosx]

On 24/01/12 10:46, Alan Bateman wrote: On 23/01/2012 22:32, Michael McMahon wrote: No, I don't think so. fd_sets are bit masks and you have to specify the highest numbered bit in the mask (+1). Sorry, I wasn't thinking, it's nfds+1. In that case, I think the change is okay although having t,

Re: RFR: 7131399: Poll system call appears to be broken on Mac OS [macosx]

On 24/01/2012 11:19, Michael McMahon wrote: Ok, I've updated the webrev to do the above and to adjust the comments http://cr.openjdk.java.net/~michaelm/7131399/webrev.2/ This looks much cleaner. I'd probably use tp = NULL myself but what you have is okay. -Alan

Re: RFR: 7131399: Poll system call appears to be broken on Mac OS [macosx]

On Mon, Jan 23, 2012 at 7:09 PM, Michael McMahon < michael.x.mcma...@oracle.com> wrote: > Can I get the following change reviewed please? > > http://cr.openjdk.java.net/~**michaelm/7131399/webrev.1/ > > The problem is that poll(2) doesn't s

Re: RFR: 7131399: Poll system call appears to be broken on Mac OS [macosx]

On 24/01/12 11:27, Damjan Jovanovic wrote: On Mon, Jan 23, 2012 at 7:09 PM, Michael McMahon mailto:michael.x.mcma...@oracle.com>> wrote: Can I get the following change reviewed please? http://cr.openjdk.java.net/~michaelm/7131399/webrev.1/

Re: RFR: 7131399: Poll system call appears to be broken on Mac OS [macosx]

On 24/01/2012 11:47, Michael McMahon wrote: Damjan, We can only deal with a finite number of file descriptors already in this file, although the actual value can be set as high as required through setrlimit(). getFdEntry() checks that the fd number is within the particular limits and all I/O

hg: jdk8/tl/jdk: 7132386: makefile support for tracing/Java Flight Recorder framework phase I

Changeset: 718bca4e685f Author:rbackman Date: 2012-01-17 16:20 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/718bca4e685f 7132386: makefile support for tracing/Java Flight Recorder framework phase I Reviewed-by: ohair, dholmes, rottenha Contributed-by: Markus Gronlund , Erik

hg: jdk8/tl/langtools: 7129801: Merge the two method applicability routines

Changeset: 51fb17abfc32 Author:mcimadamore Date: 2012-01-24 17:52 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/51fb17abfc32 7129801: Merge the two method applicability routines Summary: Resolve.java and Infer.java should reuse the same method applicability check rout

hg: jdk8/tl/jdk: 7132270: tools/launcher/DefaultLocaleTestRun.java failing (win)

Changeset: f64ea40293db Author:ksrini Date: 2012-01-24 09:58 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f64ea40293db 7132270: tools/launcher/DefaultLocaleTestRun.java failing (win) Reviewed-by: alanb, chegar ! test/tools/launcher/DefaultLocaleTestRun.java ! test/tools/la

hg: jdk8/tl/jdk: 7132879: address Findbugs issue in WebRowSetXmlWriter

Changeset: 303b67074666 Author:lancea Date: 2012-01-24 15:13 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/303b67074666 7132879: address Findbugs issue in WebRowSetXmlWriter Reviewed-by: forax ! src/share/classes/com/sun/rowset/internal/WebRowSetXmlWriter.java

Re: Code review request [JDK 8]: 7132248, sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/CookieHttpsClientTest.java failing

Looks good also... Brad On 1/23/2012 4:27 AM, Xuelei Fan wrote: Remove the serviceabilty-dev. Thanks for the quick code review. Xuelei On 1/23/2012 8:25 PM, Alan Bateman wrote: On 23/01/2012 12:21, Xuelei Fan wrote: Webrev: http://cr.openjdk.java.net/~xuelei/7132248/webrev.00/ In JDK 8,

hg: jdk8/tl/langtools: 7126832: com.sun.tools.javac.api.ClientCodeWrapper$WrappedJavaFileManager cannot be cast

Changeset: ac36176b7de0 Author:jjh Date: 2012-01-24 15:51 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ac36176b7de0 7126832: com.sun.tools.javac.api.ClientCodeWrapper$WrappedJavaFileManager cannot be cast Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/api/

hg: jdk8/tl/langtools: 7129225: javac fails to run annotation processors when star import of package of gensrc

Changeset: d16b464e742c Author:jjh Date: 2012-01-24 16:31 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d16b464e742c 7129225: javac fails to run annotation processors when star import of package of gensrc Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/