Re: Code Review 7025938: Add bitmap mime type to content-types.properties

2011-08-19 Thread Michael McMahon
Looks fine. - Michael. On 18/08/11 17:44, Chris Hegarty wrote: Can I get a review for this contribution? It adds bitmap mime type support to content-types.properties, so that URLConnection.getContentType() returns 'image/bmp' rather than 'content/unknown'. This is not a commonly used API, bu

hg: jdk8/tl/jdk: 7025938: Add bitmap mime type to content-types.properties

2011-08-19 Thread chris . hegarty
Changeset: 46b53f80ab0a Author:chegar Date: 2011-08-19 10:55 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46b53f80ab0a 7025938: Add bitmap mime type to content-types.properties Reviewed-by: chegar, alanb, michaelm Contributed-by: lvj...@linux.vnet.ibm.com ! src/solaris/lib

Re: Does OpenJDK support bitmap image with JarURLConnection?

2011-08-19 Thread Chris Hegarty
I guess you seen the changeset, but just to close the loop in this email thread. Here is a link to the JDK8 changeset: Changeset: 46b53f80ab0a Author:chegar Date: 2011-08-19 10:55 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46b53f80ab0a 7025938: Add bitmap mime type to co

Re: HttpCookie.domainMatches("hostname.local", "hostname") return false

2011-08-19 Thread Chris Hegarty
Hi Sean, I submitted a JPRT job with you patch. If all builds and tests are successful I'll push this change for you. diff -r 46b53f80ab0a src/share/classes/java/net/HttpCookie.java --- a/src/share/classes/java/net/HttpCookie.javaFri Aug 19 10:55:05 2011 +0100 +++ b/src/share/classes/

hg: jdk8/tl/jdk: 4748706: typos in java.util.Observable documentation

2011-08-19 Thread joe . darcy
Changeset: 8018d541a7b2 Author:darcy Date: 2011-08-19 17:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8018d541a7b2 4748706: typos in java.util.Observable documentation Reviewed-by: iris ! src/share/classes/java/util/Observable.java