Re: Code Review Request: 7035556 DatagramSocket.java:183: warning: unreachable catch clause

2011-07-25 Thread Chris Hegarty
The changes look fine to me. Thanks for taking care of this one. -Chris. On 07/22/11 06:31 PM, Kurchi Hazra wrote: Hi, I changed the implementation according to Brad's comments. I am reposting the output of hg diff src/share/classes/java/net/DatagramSocket.java since I don't have an openjd

hg: jdk8/tl/jdk: 7035556: DatagramSocket.java:183: warning: unreachable catch clause

2011-07-25 Thread chris . hegarty
Changeset: 07a12583d4ea Author:chegar Date: 2011-07-25 14:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/07a12583d4ea 7035556: DatagramSocket.java:183: warning: unreachable catch clause Summary: Remove redundant catches in bind Reviewed-by: alanb, michaelm, wetmore, chegar

Re: hg: jdk8/tl/jdk: 7035556: DatagramSocket.java:183: warning: unreachable catch clause

2011-07-25 Thread Chris Hegarty
Congratulation Kurchi on your first contribution to OpenJDK. Hope to see more in the future. -Chris. On 07/25/11 10:42 PM, chris.hega...@oracle.com wrote: Changeset: 07a12583d4ea Author:chegar Date: 2011-07-25 14:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/07a12583d

Re: hg: jdk8/tl/jdk: 7035556: DatagramSocket.java:183: warning: unreachable catch clause

2011-07-25 Thread Kurchi Hazra
Thanks a lot and I look forward to making more contributions too! Thanks, Kurchi On 7/25/2011 2:52 PM, Chris Hegarty wrote: Congratulation Kurchi on your first contribution to OpenJDK. Hope to see more in the future. -Chris. On 07/25/11 10:42 PM, chris.hega...@oracle.com wrote: Changeset: 0