Re: Code Review Request: 7035556 DatagramSocket.java:183: warning: unreachable catch clause

2011-07-22 Thread Michael McMahon
There seems to be only a couple of places where IOException (specifically) is thrown in the networking code and it can't occur in this code path as far as I can see. Perhaps that wasn't always the case, which could explain why the unusual construction exists. So, the simplification suggested be

Re: Code Review Request: 7035556 DatagramSocket.java:183: warning: unreachable catch clause

2011-07-22 Thread Chris Hegarty
On 7/22/2011 3:45 AM, Alan Bateman wrote: Kurchi Hazra wrote: Hi, Due to a recent update in javac to issue a warning on detecting unreachable code, the following warning started showing up in the jdk networking code: ../../../src/share/classes/java/net/DatagramSocket.java:183: warning: unrea

Re: Code Review Request: 7035556 DatagramSocket.java:183: warning: unreachable catch clause

2011-07-22 Thread Michael McMahon
On 22/07/11 13:51, Chris Hegarty wrote: On 7/22/2011 3:45 AM, Alan Bateman wrote: Kurchi Hazra wrote: Hi, Due to a recent update in javac to issue a warning on detecting unreachable code, the following warning started showing up in the jdk networking code: ../../../src/share/classes/java/net

Re: Code Review Request: 7035556 DatagramSocket.java:183: warning: unreachable catch clause

2011-07-22 Thread Chris Hegarty
On 7/22/2011 2:41 PM, Michael McMahon wrote: On 22/07/11 13:51, Chris Hegarty wrote: On 7/22/2011 3:45 AM, Alan Bateman wrote: Kurchi Hazra wrote: Hi, Due to a recent update in javac to issue a warning on detecting unreachable code, the following warning started showing up in the jdk networ

Re: Code Review Request: 7035556 DatagramSocket.java:183: warning: unreachable catch clause

2011-07-22 Thread Alan Bateman
Michael McMahon wrote: But, bind() already closes the impl internally before throwing the exception. I was wondering about that and whether this is a bug. Suppose someone creates an unbound DatagramSocket and then attempts to bind it to a port. If the bind fails (say port already in use) then i

Re: Code Review Request: 7035556 DatagramSocket.java:183: warning: unreachable catch clause

2011-07-22 Thread Michael McMahon
On 22/07/11 14:55, Alan Bateman wrote: Michael McMahon wrote: But, bind() already closes the impl internally before throwing the exception. I was wondering about that and whether this is a bug. Suppose someone creates an unbound DatagramSocket and then attempts to bind it to a port. If the bin

Re: Code Review Request: 7035556 DatagramSocket.java:183: warning: unreachable catch clause

2011-07-22 Thread Kurchi Hazra
Hi, I changed the implementation according to Brad's comments. I am reposting the output of hg diff src/share/classes/java/net/DatagramSocket.java since I don't have an openjdk account: bash-3.00$ hg diff src/share/classes/java/net/DatagramSocket.java diff --git a/src/share/classes/java/n

hg: jdk8/tl/corba: 7069993: Adjust make/jprt.properties file for jdk8

2011-07-22 Thread kelly . ohair
Changeset: 949fb60ca830 Author:ohair Date: 2011-07-22 17:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/949fb60ca830 7069993: Adjust make/jprt.properties file for jdk8 Reviewed-by: katleman ! make/jprt.properties

hg: jdk8/tl/jaxws: 7069993: Adjust make/jprt.properties file for jdk8

2011-07-22 Thread kelly . ohair
Changeset: 64df57a1edec Author:ohair Date: 2011-07-22 17:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/64df57a1edec 7069993: Adjust make/jprt.properties file for jdk8 Reviewed-by: katleman ! make/jprt.properties

hg: jdk8/tl/jdk: 2 new changesets

2011-07-22 Thread kelly . ohair
Changeset: 0ec4b6498a69 Author:ohair Date: 2011-07-22 17:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0ec4b6498a69 7069993: Adjust make/jprt.properties file for jdk8 Reviewed-by: katleman ! make/jprt.properties Changeset: a499fdfbe723 Author:ohair Date: 2011-0

hg: jdk8/tl/jaxp: 7069993: Adjust make/jprt.properties file for jdk8

2011-07-22 Thread kelly . ohair
Changeset: 4f0fcb812767 Author:ohair Date: 2011-07-22 17:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/4f0fcb812767 7069993: Adjust make/jprt.properties file for jdk8 Reviewed-by: katleman ! make/jprt.properties

hg: jdk8/tl: 2 new changesets

2011-07-22 Thread kelly . ohair
Changeset: fd8615098a54 Author:ohair Date: 2011-07-22 17:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/fd8615098a54 7069993: Adjust make/jprt.properties file for jdk8 Reviewed-by: katleman ! make/jprt.properties Changeset: f42e3d9394b4 Author:ohair Date: 2011-07-22

hg: jdk8/tl/langtools: 2 new changesets

2011-07-22 Thread kelly . ohair
Changeset: 2d3096441387 Author:ohair Date: 2011-07-22 17:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2d3096441387 7069993: Adjust make/jprt.properties file for jdk8 Reviewed-by: katleman ! make/jprt.properties Changeset: 36f31b87b0ab Author:ohair Date: