Re: Code Review 6964547: Impossible to set useV4 in SocksSocketImpl

2011-01-13 Thread Chris Hegarty
On 01/12/11 06:25 PM, Alan Bateman wrote: Chris Hegarty wrote: : Updated Webrev: http://cr.openjdk.java.net/~chegar/6964547/webrev.02/webrev/ Looks fine except that that main thread needs to wait for the "socks server" thread to terminate as otherwise the test might pass before the thread sets

Re: Code Review 6964547: Impossible to set useV4 in SocksSocketImpl

2011-01-13 Thread Alan Bateman
Chris Hegarty wrote: : Ah yes, I just moved the socket close to after the version check. The client will be blocked (in the socks protocol handhake) until the socket on the server side is closed. Updated test: http://cr.openjdk.java.net/~chegar/6964547/webrev.02/webrev/test/java/net/Socks/So

Re: Code Review 6964547: Impossible to set useV4 in SocksSocketImpl

2011-01-13 Thread Chris Hegarty
On 01/13/11 09:29 AM, Alan Bateman wrote: Chris Hegarty wrote: : Ah yes, I just moved the socket close to after the version check. The client will be blocked (in the socks protocol handhake) until the socket on the server side is closed. Updated test: http://cr.openjdk.java.net/~chegar/6964547

Re: Code Review 6964547: Impossible to set useV4 in SocksSocketImpl

2011-01-13 Thread Alan Bateman
Chris Hegarty wrote: : Yes, I should know better ( after trying to debug many of these spurious failures ). http://cr.openjdk.java.net/~chegar/6964547/webrev.02/webrev/test/java/net/Socks/SocksProxyVersion.java.html This looks fine to me. -Alan

hg: jdk7/tl/jdk: 2 new changesets

2011-01-13 Thread michael . x . mcmahon
Changeset: 538f913777cf Author:michaelm Date: 2011-01-13 11:01 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/538f913777cf 6896088: URLClassLoader.close() apparently not working for JAR URLs on Windows Reviewed-by: chegar ! src/share/classes/sun/misc/URLClassPath.java + test

hg: jdk7/tl/jdk: 6964547: Impossible to set useV4 in SocksSocketImpl

2011-01-13 Thread chris . hegarty
Changeset: 694951adefec Author:chegar Date: 2011-01-13 13:24 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/694951adefec 6964547: Impossible to set useV4 in SocksSocketImpl Summary: Add socksProxyVersion property Reviewed-by: alanb, michaelm ! make/sun/net/FILES_java.gmk ! s

hg: jdk7/tl/jdk: 3 new changesets

2011-01-13 Thread michael . x . mcmahon
Changeset: 38729ba6eb4f Author:michaelm Date: 2011-01-12 15:05 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/38729ba6eb4f 6829919: URLClassLoader.close() doesn't close resource file if getResourceAsStream(...) was called before Reviewed-by: chegar ! src/share/classes/java/

hg: jdk7/tl/jdk: 7003398: NetworkInterface equals() and hashCode() behaviors depend on permissions granted

2011-01-13 Thread michael . x . mcmahon
Changeset: 3215b22cd90e Author:michaelm Date: 2011-01-13 16:33 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3215b22cd90e 7003398: NetworkInterface equals() and hashCode() behaviors depend on permissions granted Reviewed-by: chegar, alanb ! src/share/classes/java/net/Netwo

hg: jdk7/tl/langtools: 6430241: Hard to disable symbol file feature through API

2011-01-13 Thread jonathan . gibbons
Changeset: d33d8c381aa1 Author:jjg Date: 2011-01-13 11:48 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d33d8c381aa1 6430241: Hard to disable symbol file feature through API Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java !

hg: jdk7/tl/jdk: 6728865: Provide a better heuristics for Collections.disjoint method

2011-01-13 Thread mike . duigou
Changeset: 29f2e311cce7 Author:mduigou Date: 2011-01-13 20:32 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/29f2e311cce7 6728865: Provide a better heuristics for Collections.disjoint method Reviewed-by: alanb, dholmes, chegar, forax ! src/share/classes/java/util/Collections

hg: jdk7/tl/langtools: 7010528: javadoc performance regression

2011-01-13 Thread bhavesh . patel
Changeset: a466f00c5cd2 Author:bpatel Date: 2011-01-13 21:28 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/a466f00c5cd2 7010528: javadoc performance regression Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java ! src/share/cla

hg: jdk7/tl/jdk: 7012279: Project Coin: Clarify AutoCloseable and Throwable javadoc

2011-01-13 Thread joe . darcy
Changeset: 59e352561146 Author:darcy Date: 2011-01-13 22:21 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/59e352561146 7012279: Project Coin: Clarify AutoCloseable and Throwable javadoc Reviewed-by: jjb ! src/share/classes/java/lang/AutoCloseable.java ! src/share/classes/ja