6989190: SO_SNDBUF/SO_RCVBUF limits should only be checked when setsockopt fails (sol)

2010-10-04 Thread Alan Bateman
I need a reviewer for a small change to the networking code. On Solaris, the SO_SNDBUF/SO_RCVBUF parameters are clamped by the values of the tcp_max_buf and udp_max_buf parameters. Unfortunately the code in net_util_md.c has been using a private/unsupported interface that no longer exists in

Re: 6989190: SO_SNDBUF/SO_RCVBUF limits should only be checked when setsockopt fails (sol)

2010-10-04 Thread Michael McMahon
Looks fine. Thanks, Michael. Alan Bateman wrote: I need a reviewer for a small change to the networking code. On Solaris, the SO_SNDBUF/SO_RCVBUF parameters are clamped by the values of the tcp_max_buf and udp_max_buf parameters. Unfortunately the code in net_util_md.c has been using a priv

Re: 6989190: SO_SNDBUF/SO_RCVBUF limits should only be checked when setsockopt fails (sol)

2010-10-04 Thread Chris Hegarty
The change seems reasonable. -Chris. Alan Bateman wrote: I need a reviewer for a small change to the networking code. On Solaris, the SO_SNDBUF/SO_RCVBUF parameters are clamped by the values of the tcp_max_buf and udp_max_buf parameters. Unfortunately the code in net_util_md.c has been usin

hg: jdk7/tl/jdk: 6989190: SO_SNDBUF/SO_RCVBUF limits should only be checked when setsockopt fails (sol)

2010-10-04 Thread alan . bateman
Changeset: b8af3bab5dbf Author:alanb Date: 2010-10-04 14:17 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b8af3bab5dbf 6989190: SO_SNDBUF/SO_RCVBUF limits should only be checked when setsockopt fails (sol) Reviewed-by: chegar, michaelm ! src/solaris/native/java/net/net_uti

hg: jdk7/tl/jdk: 6907737: (file) FileVisitor and Files.walkFileTree issues

2010-10-04 Thread alan . bateman
Changeset: 81b0c1e3d5a7 Author:alanb Date: 2010-10-03 19:39 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/81b0c1e3d5a7 6907737: (file) FileVisitor and Files.walkFileTree issues Reviewed-by: sherman + src/share/classes/java/nio/file/FileSystemLoopException.java ! src/share/c

hg: jdk7/tl/langtools: 6907737: (file) FileVisitor and Files.walkFileTree issues

2010-10-04 Thread alan . bateman
Changeset: 232919708730 Author:alanb Date: 2010-10-03 19:40 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/232919708730 6907737: (file) FileVisitor and Files.walkFileTree issues Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/nio/JavacPathFileManager.java

hg: jdk7/tl/jdk: 6989139: Address JDBC Findbugs where Number type Constructor are used

2010-10-04 Thread lance . andersen
Changeset: ffaf6a35b895 Author:lancea Date: 2010-10-04 13:04 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ffaf6a35b895 6989139: Address JDBC Findbugs where Number type Constructor are used Reviewed-by: ohair ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java ! src/sh