Request for Review: 6909089

2009-12-10 Thread Christopher Hegarty -Sun Microsystems Ireland
CR 6909089: Memory leak occurs by lack of free for read buffer in SocketInputStream#read() Webrev: http://cr.openjdk.java.net/~chegar/6909089/webrev.0/webrev/ Bug description says it all. -Chris.

Re: Request for Review: 6909089

2009-12-10 Thread Alan Bateman
Christopher Hegarty -Sun Microsystems Ireland wrote: CR 6909089: Memory leak occurs by lack of free for read buffer in SocketInputStream#read() Webrev: http://cr.openjdk.java.net/~chegar/6909089/webrev.0/webrev/ Bug description says it all. -Chris. Looks okay to me - I assume you've che

Re: Request for Review: 6909089

2009-12-10 Thread Jean-Christophe Collet
I approve this change. On 12/10/09 16:35, Christopher Hegarty -Sun Microsystems Ireland wrote: CR 6909089: Memory leak occurs by lack of free for read buffer in SocketInputStream#read() Webrev: http://cr.openjdk.java.net/~chegar/6909089/webrev.0/webrev/ Bug description says it all. -Chr

Re: Request for Review: 6909089

2009-12-10 Thread Christopher Hegarty -Sun Microsystems Ireland
Alan Bateman wrote: Christopher Hegarty -Sun Microsystems Ireland wrote: CR 6909089: Memory leak occurs by lack of free for read buffer in SocketInputStream#read() Webrev: http://cr.openjdk.java.net/~chegar/6909089/webrev.0/webrev/ Bug description says it all. -Chris. Looks okay to me

Re: Request for Review: 6909089

2009-12-10 Thread Michael McMahon
Alan Bateman wrote: Christopher Hegarty -Sun Microsystems Ireland wrote: CR 6909089: Memory leak occurs by lack of free for read buffer in SocketInputStream#read() Webrev: http://cr.openjdk.java.net/~chegar/6909089/webrev.0/webrev/ Bug description says it all. -Chris. Looks okay to me -

hg: jdk7/tl/jdk: 2 new changesets

2009-12-10 Thread christopher . hegarty
Changeset: ae944611249f Author:chegar Date: 2009-12-10 15:52 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ae944611249f 6909089: Memory leak occurs by lack of free for read buffer in SocketInputStream#read() Reviewed-by: alanb, jccollet ! src/windows/native/java/net/Socket

hg: jdk7/tl/jdk: 6909070: Missing package statements in java.text.Bidi @see links

2009-12-10 Thread joe . darcy
Changeset: f9c9c2b726a0 Author:darcy Date: 2009-12-10 13:04 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f9c9c2b726a0 6909070: Missing package statements in java.text.Bidi @see links Reviewed-by: anthony ! src/share/classes/java/text/Bidi.java

hg: jdk7/tl/jdk: 4891262: API spec, javax/accessibility: few invalid javadoc tags

2009-12-10 Thread joe . darcy
Changeset: aa0d374b40a5 Author:darcy Date: 2009-12-10 13:28 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/aa0d374b40a5 4891262: API spec, javax/accessibility: few invalid javadoc tags Reviewed-by: jjg ! src/share/classes/javax/accessibility/AccessibleContext.java ! src/shar

hg: jdk7/tl/langtools: 6909538: Clarify meaning of "element" in javax.lang.model.element API

2009-12-10 Thread joe . darcy
Changeset: ff823a039e16 Author:darcy Date: 2009-12-10 20:35 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/ff823a039e16 6909538: Clarify meaning of "element" in javax.lang.model.element API Reviewed-by: ahe ! src/share/classes/javax/lang/model/element/package-info.java