Re: hg: jdk7/tl/jdk: 6730652: CharsetEncoder.canEncode(char) returns incorrect values for some charsets

2009-08-15 Thread Ulf Zibis
My tiny comment: It would suffice, to make the constants package private, instead of public. -Ulf Am 14.08.2009 23:39, xueming.s...@sun.com schrieb: Changeset: 77a1c2056565 Author:sherman Date: 2009-08-14 14:29 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/77a1c2056565

Re: hg: jdk7/tl/jdk: 4116222: Errors in Arabic code-conversion tables, part II

2009-08-15 Thread Ulf Zibis
Hi Sherman, I've seen, that you have again changed GenerateSBCS.java I like to remember to review my changes on: https://bugs.openjdk.java.net/attachment.cgi?id=130&action=diff#a/make/tools/src/build/tools/charsetmapping/GenerateSBCS.java_sec1 IMHO my code is much smarter, and faster too (saves