Request for Review 6855335

2009-06-29 Thread Christopher Hegarty - Sun Microsystems Ireland
Hi Michael, Jessie, I need a code review for some SCTP changes that were found during testing. CR 6855335: Several changes in the SCTP implementation. Webrev: http://cr.openjdk.java.net/~chegar/6855335/webrev.00/webrev/ 1) SctpMultiChannel.branch returns null. branch was not implemented

Re: Request for Review 6855335

2009-06-29 Thread Michael McMahon
Christopher Hegarty - Sun Microsystems Ireland wrote: Hi Michael, Jessie, I need a code review for some SCTP changes that were found during testing. CR 6855335: Several changes in the SCTP implementation. Webrev: http://cr.openjdk.java.net/~chegar/6855335/webrev.00/webrev/ 1) SctpMultiC

Re: Request for Review 6855335

2009-06-29 Thread Christopher Hegarty - Sun Microsystems Ireland
On 29/06/2009 11:32, Michael McMahon wrote: Christopher Hegarty - Sun Microsystems Ireland wrote: Hi Michael, Jessie, I need a code review for some SCTP changes that were found during testing. CR 6855335: Several changes in the SCTP implementation. Webrev: http://cr.openjdk.java.net/~ch

Re: Request for Review 6855335

2009-06-29 Thread Michael McMahon
Christopher Hegarty - Sun Microsystems Ireland wrote: On 29/06/2009 11:32, Michael McMahon wrote: Christopher Hegarty - Sun Microsystems Ireland wrote: Hi Michael, Jessie, I need a code review for some SCTP changes that were found during testing. CR 6855335: Several changes in the SCTP im

hg: jdk7/tl/jdk: 2 new changesets

2009-06-29 Thread michael . mcmahon
Changeset: 806c5e4d1265 Author:michaelm Date: 2009-06-29 13:10 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/806c5e4d1265 6513803: httpserver regression test Test13 failing and causing NullPointerException Summary: check for NPEs Reviewed-by: chegar ! test/com/sun/net/http

hg: jdk7/tl/jdk: 6855335: Several changes in the SCTP implementation.

2009-06-29 Thread christopher . hegarty
Changeset: a44009aba19f Author:chegar Date: 2009-06-29 14:53 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a44009aba19f 6855335: Several changes in the SCTP implementation. Reviewed-by: michaelm ! make/com/sun/nio/sctp/mapfile-vers ! src/solaris/classes/sun/nio/ch/SctpChann

hg: jdk7/tl/jdk: 2 new changesets

2009-06-29 Thread michael . mcmahon
Changeset: 89b14d3740dc Author:michaelm Date: 2009-06-29 15:05 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/89b14d3740dc 6827999: 6827999: URLClassLoader.addURL(URL) adds URLs to closed class loader Reviewed-by: chegar ! src/share/classes/sun/misc/URLClassPath.java + test/

hg: jdk7/tl/jdk: 6855069: rmic should support v51 class files.

2009-06-29 Thread jonathan . gibbons
Changeset: d926534a1c17 Author:jjg Date: 2009-06-29 16:28 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d926534a1c17 6855069: rmic should support v51 class files. Reviewed-by: jrose ! src/share/classes/sun/tools/java/RuntimeConstants.java

hg: jdk7/tl/langtools: 6855993: fix comments in langtools launcher script

2009-06-29 Thread jonathan . gibbons
Changeset: 7913e72a24b0 Author:jjg Date: 2009-06-29 17:45 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/7913e72a24b0 6855993: fix comments in langtools launcher script Reviewed-by: ohair ! src/share/bin/launcher.sh-template

hg: jdk7/tl/jdk: 6855671: DerOutputStream encodes negative integer incorrectly

2009-06-29 Thread weijun . wang
Changeset: 605d3fa6764e Author:weijun Date: 2009-06-30 11:55 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/605d3fa6764e 6855671: DerOutputStream encodes negative integer incorrectly Reviewed-by: xuelei ! src/share/classes/sun/security/util/DerOutputStream.java + test/sun/se

hg: jdk7/tl/jdk: 2 new changesets

2009-06-29 Thread xueming . shen
Changeset: 1cc9eb0c952e Author:sherman Date: 2009-06-29 19:57 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1cc9eb0c952e 6707281: Adler32.update() JavaDoc is wrong 6553961: java.util.zip.{CRC32,Adler32}.update(int) doc errors 6646605: Missing method ZipFile.getComment() 6841