Re: Code review for 6644726: Cookie management issues

2008-04-16 Thread Christopher Hegarty - Sun Microsystems Ireland
This change looks good. -Chris. Jean-Christophe Collet wrote: Here are my proposed changes to fix 6644726 It does fix all 7 issues listed in the CR (see http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6644726 for details) and adds a proper regression test. The short list is: - support f

6687282 code review

2008-04-16 Thread Christopher Hegarty - Sun Microsystems Ireland
Hi, I need to get a code review for, CR 6687282 : "URLConnection for HTTPS connection through Proxy w/ Digest Authentication gives 400 Bad Request". Digest authentication uses the request-URI as part of its algorithm when generating the response hash. The request-URI is usually the abs_path

Re: 6687282 code review

2008-04-16 Thread Michael McMahon
Looks ok to me. - Michael. Christopher Hegarty - Sun Microsystems Ireland wrote: Hi, I need to get a code review for, CR 6687282 : "URLConnection for HTTPS connection through Proxy w/ Digest Authentication gives 400 Bad Request". Digest authentication uses the request-URI as part of its a

hg: jdk7/jsn/jdk: 6687282: URLConnection for HTTPS connection through Proxy w/ Digest Authentication gives 400 Bad Request

2008-04-16 Thread christopher . hegarty
Changeset: a954a6f3be6f Author:chegar Date: 2008-04-16 14:17 +0100 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/a954a6f3be6f 6687282: URLConnection for HTTPS connection through Proxy w/ Digest Authentication gives 400 Bad Request Summary: Change http/digest implementation to us