CR 6667108 code review

2008-03-07 Thread Christopher Hegarty - Sun Microsystems Ireland
CR 6667108: "typo in javadoc for java.net.Socket.getRemoteSocketAddress()" Trivial cleanup of a typo in getRemoteSocketAddress specification. diff -r fa6948bdc4b0 src/share/classes/java/net/Socket.java --- a/src/share/classes/java/net/Socket.javaThu Mar 06 10:35:28 2008 -0800 +++ b/src/sha

Re: CR 6667108 code review

2008-03-07 Thread Jean-Christophe Collet
Approved. Christopher Hegarty - Sun Microsystems Ireland wrote: CR 6667108: "typo in javadoc for java.net.Socket.getRemoteSocketAddress()" Trivial cleanup of a typo in getRemoteSocketAddress specification. diff -r fa6948bdc4b0 src/share/classes/java/net/Socket.java --- a/src/share/classes/ja

hg: jdk7/jsn/jdk: 6667108: typo in javadoc for java.net.Socket.getRemoteSocketAddress()

2008-03-07 Thread christopher . hegarty
Changeset: a100f699c155 Author:chegar Date: 2008-03-07 09:57 + URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/a100f699c155 6667108: typo in javadoc for java.net.Socket.getRemoteSocketAddress() Summary: Simple typo in method specification. Reviewed-by: jccollet ! src/share/cla

Re: JSN gate notifications.

2008-03-07 Thread Christopher Hegarty - Sun Microsystems Ireland
Thanks Brad, this is great. -Chris. Brad Wetmore wrote: Hi net-dev'ers, This is Brad Wetmore, your friendly neighborhood JSN gatekeeper. For some reason, pushes to the various JSN gates were initially configured to send notifications only to the security group's aliases. That problem has

hg: jdk7/jsn/jdk: 6615656: Removed unimplemented java.net methods

2008-03-07 Thread christopher . hegarty
Changeset: 328415dfe347 Author:chegar Date: 2008-03-07 11:30 + URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/328415dfe347 6615656: Removed unimplemented java.net methods Reviewed-by: jccollet ! src/share/classes/java/net/AbstractPlainSocketImpl.java ! src/share/classes/java/

Re: CR 6591358 code review

2008-03-07 Thread Jean-Christophe Collet
Approved. Christopher Hegarty - Sun Microsystems Ireland wrote: Another trivial documentation change. CR 6591358: "documentation error in URLConnection.setRequestProperty("accept", ...)" -Chris.

hg: jdk7/jsn/jdk: 6591358: documentation error in URLConnection.setRequestProperty("accept", ...)

2008-03-07 Thread christopher . hegarty
Changeset: 10d5be3e1fa8 Author:chegar Date: 2008-03-07 11:51 + URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/10d5be3e1fa8 6591358: documentation error in URLConnection.setRequestProperty("accept", ...) Summary: Simple doc change, "accept" -> "Accept" Reviewed-by: jccollet !

CR 6591358 code review

2008-03-07 Thread Christopher Hegarty - Sun Microsystems Ireland
Another trivial documentation change. CR 6591358: "documentation error in URLConnection.setRequestProperty("accept", ...)" -Chris. --- old/src/share/classes/java/net/URLConnection.java Fri Mar 7 11:19:24 2008 +++ new/src/share/classes/java/net/URLConnection.java Fri Mar 7 11:19:24 2008 @@

hg: jdk7/jsn/jdk: 6628576: InterfaceAddress.equals() NPE when broadcast field == null

2008-03-07 Thread christopher . hegarty
Changeset: 50a8b5ca8f39 Author:chegar Date: 2008-03-07 13:00 + URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/50a8b5ca8f39 6628576: InterfaceAddress.equals() NPE when broadcast field == null Summary: Update logic in equals to correctly handle nulls. Reviewed-by: michaelm ! sr