Re: code review request: 6911951: NTLM should be a supported Java SASL mechanism

2010-08-26 Thread Michael McMahon
Weijun Wang wrote: The internal structure of NTLMAuthentication is changed and that's why I changed the serialVersionUid as well. If unchanged, I guess the old serialized form can still be accepted by the new class, but all new field will become null/0. After the change, any such deserializatio

Re: code review request: 6911951: NTLM should be a supported Java SASL mechanism

2010-08-26 Thread Weijun Wang
The internal structure of NTLMAuthentication is changed and that's why I changed the serialVersionUid as well. If unchanged, I guess the old serialized form can still be accepted by the new class, but all new field will become null/0. After the change, any such deserialization should throw a ex

Re: code review request: 6911951: NTLM should be a supported Java SASL mechanism

2010-08-26 Thread Michael McMahon
Why is the serialVersionUid changed in NTLMAuthentication? Otherwise, the encapsulation of NTLM in the new API looks quite concise and neat to me? Looks fine. - Michael Vincent Ryan wrote: The SASL component looks good Max. Michael/Chris: have you any comments on the NTLM changes? On 25/0

Re: code review request: 6911951: NTLM should be a supported Java SASL mechanism

2010-08-25 Thread Vincent Ryan
The SASL component looks good Max. Michael/Chris: have you any comments on the NTLM changes? On 25/08/2010 06:23, Weijun Wang wrote: > Ping again. > > The webrev is updated: >http://cr.openjdk.java.net/~weijun/6911951/webrev.01/ > > The CCC is about to be finalized: >http://ccc.sfbay.

code review request: 6911951: NTLM should be a supported Java SASL mechanism

2010-08-24 Thread Weijun Wang
Ping again. The webrev is updated: http://cr.openjdk.java.net/~weijun/6911951/webrev.01/ The CCC is about to be finalized: http://ccc.sfbay.sun.com/6911951 Thanks Max On 04/16/2010 11:12 AM, Weijun Wang wrote: Vinnie Please take a review on this webrev: cr.openjdk.java.net/~weijun