Re: Two Review requests

2012-09-28 Thread Dmitry Samersoff
John, > File Descriptor Leak: > http://cr.openjdk.java.net/~chegar/8000203/webrev.00/ > (Jira bug ID number: 8000203) (*it's not to your changes but as far as you touch this code *) 607 else is not needed here 609 realloc should not touch original pointer in case of fail, so this code le

Re: Two Review requests

2012-09-28 Thread Chris Hegarty
On 28/09/12 15:11, John Zavgren wrote: Greetings: I just posted the webrev images for two networking code bugs: File Descriptor Leak: http://cr.openjdk.java.net/~chegar/8000203/webrev.00/ (Jira bug ID number: 8000203) Looks good. Uninitialized memory: http://cr.openjdk.java.net/~chegar/8000

Two Review requests

2012-09-28 Thread John Zavgren
Greetings: I just posted the webrev images for two networking code bugs: File Descriptor Leak: http://cr.openjdk.java.net/~chegar/8000203/webrev.00/ (Jira bug ID number: 8000203) Uninitialized memory: http://cr.openjdk.java.net/~chegar/8000206/webrev.00/ (Jira bug ID: 8000206) This change doesn'