Re: Request for Review: 6905552

2010-01-27 Thread Alan Bateman
Christopher Hegarty - Sun Microsystems Ireland wrote: : What we found is that on Solaris if an interface has only IPv6 addresses assigned to it, then you need to use a socket created with AF_INET6 when querying the ioclt. By default, we always try to with an AF_INET socket first and on Solaris

Re: Request for Review: 6905552

2010-01-27 Thread Christopher Hegarty - Sun Microsystems Ireland
On 27/01/2010 14:55, Alan Bateman wrote: Christopher Hegarty - Sun Microsystems Ireland wrote: Hi Alan, Michael, Since we don't typically build on non-IPv6 systems, over a number of years the net/nio code has not maintained clean non-IPv6 code. This patch addresses that by excluding IPv6 spec

Re: Request for Review: 6905552

2010-01-27 Thread Alan Bateman
Christopher Hegarty - Sun Microsystems Ireland wrote: Hi Alan, Michael, Since we don't typically build on non-IPv6 systems, over a number of years the net/nio code has not maintained clean non-IPv6 code. This patch addresses that by excluding IPv6 specific code where AF_INET6 is not defined.

Request for Review: 6905552

2010-01-25 Thread Christopher Hegarty - Sun Microsystems Ireland
Hi Alan, Michael, Since we don't typically build on non-IPv6 systems, over a number of years the net/nio code has not maintained clean non-IPv6 code. This patch addresses that by excluding IPv6 specific code where AF_INET6 is not defined. 6905552: libnet/nio portability issues Webrev: http