Re: Request for Review: 6893238

2009-10-21 Thread Christopher Hegarty - Sun Microsystems Ireland
On 21/10/2009 15:47, Alan Bateman wrote: Christopher Hegarty - Sun Microsystems Ireland wrote: : Yes, this would certainly be cleaner. I've updated the webrev. Please take a look. http://cr.openjdk.java.net/~chegar/6893238/webrev.1/webrev/ Note: The lack of the initial cause of the IOExc

Re: Request for Review: 6893238

2009-10-21 Thread Alan Bateman
Christopher Hegarty - Sun Microsystems Ireland wrote: : Yes, this would certainly be cleaner. I've updated the webrev. Please take a look. http://cr.openjdk.java.net/~chegar/6893238/webrev.1/webrev/ Note: The lack of the initial cause of the IOException in firstToken should not be a proble

Re: Request for Review: 6893238

2009-10-21 Thread Christopher Hegarty - Sun Microsystems Ireland
On 21/10/2009 15:05, Alan Bateman wrote: Christopher Hegarty - Sun Microsystems Ireland wrote: CR 6893238: Move NTLM and SPNEGO implementations into separate packages Webrev: http://cr.openjdk.java.net/~chegar/6893238/webrev.0/webrev/ Following 688259, NTLM and SPNEGO authentication implemen

Re: Request for Review: 6893238

2009-10-21 Thread Alan Bateman
Christopher Hegarty - Sun Microsystems Ireland wrote: CR 6893238: Move NTLM and SPNEGO implementations into separate packages Webrev: http://cr.openjdk.java.net/~chegar/6893238/webrev.0/webrev/ Following 688259, NTLM and SPNEGO authentication implementations are now runtime dependencies. The

Re: Request for Review: 6893238

2009-10-21 Thread Michael McMahon
Christopher Hegarty - Sun Microsystems Ireland wrote: CR 6893238: Move NTLM and SPNEGO implementations into separate packages Webrev: http://cr.openjdk.java.net/~chegar/6893238/webrev.0/webrev/ Following 688259, NTLM and SPNEGO authentication implementations are now runtime dependencies. The

Request for Review: 6893238

2009-10-21 Thread Christopher Hegarty - Sun Microsystems Ireland
CR 6893238: Move NTLM and SPNEGO implementations into separate packages Webrev: http://cr.openjdk.java.net/~chegar/6893238/webrev.0/webrev/ Following 688259, NTLM and SPNEGO authentication implementations are now runtime dependencies. There is no reason that their implementations should resi