eset: 16e83058
Author:Michael McMahon
URL:
https://git.openjdk.java.net/jdk/commit/16e83058cab4dd4d4a3fba812c8fe50e4286bd22
Stats: 6 lines in 2 files changed: 0 ins; 4 del; 2 mod
8273059: Redundant Math.min call in Http2ClientImpl#getConnectionWindowSize
Reviewed-by: dfuchs
---
On Fri, 27 Aug 2021 16:11:49 GMT, Michael McMahon wrote:
>> Hi,
>>
>> Could I get the following trivial change reviewed please?
>> It removes a redundant call to Math.min(Integer.MAX_VALUE, )
>>
>> Thanks,
>> Michael.
>
> Michael McMahon has updated the pull request incrementally with one
> Hi,
>
> Could I get the following trivial change reviewed please?
> It removes a redundant call to Math.min(Integer.MAX_VALUE, )
>
> Thanks,
> Michael.
Michael McMahon has updated the pull request incrementally with one additional
commit since the last revision:
mistake in last commit
On Fri, 27 Aug 2021 13:28:51 GMT, Michael McMahon wrote:
>> Hi,
>>
>> Could I get the following trivial change reviewed please?
>> It removes a redundant call to Math.min(Integer.MAX_VALUE, )
>>
>> Thanks,
>> Michael.
>
> Michael McMahon has updated the pull request incrementally with one
> Hi,
>
> Could I get the following trivial change reviewed please?
> It removes a redundant call to Math.min(Integer.MAX_VALUE, )
>
> Thanks,
> Michael.
Michael McMahon has updated the pull request incrementally with one additional
commit since the last revision:
Removed second chunk of
On Fri, 27 Aug 2021 12:01:25 GMT, Michael McMahon wrote:
> Hi,
>
> Could I get the following trivial change reviewed please?
> It removes a redundant call to Math.min(Integer.MAX_VALUE, )
>
> Thanks,
> Michael.
Marked as reviewed by dfuchs (Reviewer).
-
PR: https://git.openjd
Hi,
Could I get the following trivial change reviewed please?
It removes a redundant call to Math.min(Integer.MAX_VALUE, )
Thanks,
Michael.
-
Commit messages:
- Removed redundant Math.min() call
Changes: https://git.openjdk.java.net/jdk/pull/5277/files
Webrev: https://webrevs
Thanks. I have filed https://bugs.openjdk.java.net/browse/JDK-8273059 to
track this.
- Michael.
On 19/08/2021 19:50, Andrey Turbanov wrote:
Hello.
During investigation of results of IDEA inspections I found a
redundant call to Math.min in a method
jdk.internal.net.http.Http2ClientImpl#getConn
Hello.
During investigation of results of IDEA inspections I found a
redundant call to Math.min in a method
jdk.internal.net.http.Http2ClientImpl#getConnectionWindowSize
https://github.com/openjdk/jdk/blob/master/src/java.net.http/share/classes/jdk/internal/net/http/Http2ClientImpl.java#L240
int
