Re: URI ignores invalid ipv6 address while parsing authority

2011-04-26 Thread Jing LV
于 2011-3-1 20:44, Chris Hegarty 写道: > On 03/ 1/11 09:58 AM, Jing LV wrote: >> Hello, >> >> According to authority component RFC2396, if host name is a domain name >> there should be no "[" and "]". However if we put a hostname like >> "[www.abc.com]" while creating a URI, it silently accept, no err

Re: URI ignores invalid ipv6 address while parsing authority

2011-03-11 Thread Chris Hegarty
JDK7 changeset [1]: Changeset: 3fdfa11ea5ac Author:chegar Date: 2011-03-11 13:50 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3fdfa11ea5ac 7023363: URI("ftp", "[www.abc.com]", "/dir1/dir2", "query", "frag") should throw URISyntaxException Reviewed-by: alanb, michaelm ! sr

Re: URI ignores invalid ipv6 address while parsing authority

2011-03-11 Thread Alan Bateman
Chris Hegarty wrote: : Here is a webrev containing the implementation as described above, i.e. appendAuthority correctly adds the given authority rather than just ignoring it. parseHierarchical will throw URISyntaxException. I've also updated the existing URI Test to include this case. http://c

Re: URI ignores invalid ipv6 address while parsing authority

2011-03-10 Thread Chris Hegarty
Alan, Michael, Could you please take a look at the webrev below. On 03/ 8/11 12:15 PM, Chris Hegarty wrote: > On 03/ 8/11 09:21 AM, Jing LV wrote: >> >> (I am not sure but it seems the mail was not sent successfully - sorry if >> you receive it twice!) >> Thanks Chris. I see the bug 7023363

Re: URI ignores invalid ipv6 address while parsing authority

2011-03-08 Thread Chris Hegarty
On 03/ 8/11 09:21 AM, Jing LV wrote: > > (I am not sure but it seems the mail was not sent successfully - sorry if you > receive it twice!) > Thanks Chris. I see the bug 7023363 online. I wonder is there a fix now? > I find that we may add an else block at the end of the > URI.appendAuthority

Re: URI ignores invalid ipv6 address while parsing authority

2011-03-08 Thread Jing LV
于 2011-3-1 20:44, Chris Hegarty 写道: > On 03/ 1/11 09:58 AM, Jing LV wrote: >> Hello, >> >> According to authority component RFC2396, if host name is a domain name >> there should be no "[" and "]". However if we put a hostname like >> "[www.abc.com]" while creating a URI, it silently accept, no err

Re: URI ignores invalid ipv6 address while parsing authority

2011-03-01 Thread Chris Hegarty
On 03/ 1/11 09:58 AM, Jing LV wrote: > Hello, > > According to authority component RFC2396, if host name is a domain name > there should be no "[" and "]". However if we put a hostname like > "[www.abc.com]" while creating a URI, it silently accept, no error is > reported. I suppose this is a bug.