Re: Request for Review 6837982

2009-05-07 Thread Christopher Hegarty - Sun Microsystems Ireland
I filed the follow bug for this: 6838450: Sun specific APIs should have consistent copyright footer -Chris. On 05/07/09 12:10, Alan Bateman wrote: Christopher Hegarty - Sun Microsystems Ireland wrote: Great, thanks Max, I've added the footer and updated the webrev http://cr.openjdk.java.

Re: Request for Review 6837982

2009-05-07 Thread Alan Bateman
Christopher Hegarty - Sun Microsystems Ireland wrote: Great, thanks Max, I've added the footer and updated the webrev http://cr.openjdk.java.net/~chegar/6837982/webrev.01/webrev -Chris. It seems like we don't have consistently here in that the javadoc for some of the other supported com.sun

Re: Request for Review 6837982

2009-05-07 Thread Christopher Hegarty - Sun Microsystems Ireland
Great, thanks Max, I've added the footer and updated the webrev http://cr.openjdk.java.net/~chegar/6837982/webrev.01/webrev -Chris. On 05/07/09 03:47, Max (Weijun) Wang wrote: How about a -bottom in the flags? We didn't provide it also, until getting this bug: 6550221: jaas, jgss and smar

Re: Request for Review 6837982

2009-05-06 Thread Max (Weijun) Wang
How about a -bottom in the flags? We didn't provide it also, until getting this bug: 6550221: jaas, jgss and smartcardio javadoc files do not contain Copyrights Thanks Max On May 6, 2009, at 11:28 PM, Christopher Hegarty - Sun Microsystems Ireland wrote: Hi Jessie, Michael, Alan, I wou

Re: Request for Review 6837982

2009-05-06 Thread Alan Bateman
Christopher Hegarty - Sun Microsystems Ireland wrote: Hi Jessie, Michael, Alan, I would like to try and get this simple change into b59 through the build integration slot, and therefore make M3. The change is simply to the docs Makefile so that the SCTP API docs are generated. CR 6837982:

Re: Request for Review 6837982

2009-05-06 Thread Jean-Christophe Collet
I approve these changes. Christopher Hegarty - Sun Microsystems Ireland wrote: Hi Jessie, Michael, Alan, I would like to try and get this simple change into b59 through the build integration slot, and therefore make M3. The change is simply to the docs Makefile so that the SCTP API docs are g