Re: RFR JDK7188517

2013-05-31 Thread Kurchi Hazra
reinstated the old test. http://cr.openjdk.java.net/~jzavgren/7188517/webrev.03/ John - Original Message - From: chris.hega...@oracle.com To: john.zavg...@oracle.com Cc: kurchi.subhra.ha...@oracle.com, net-dev@openjdk.java.net Sent: Thursday, May 9, 2013 4:39:29 AM GMT -05:00 US/Canada Eastern Subject: Re:

Re: RFR JDK7188517

2013-05-31 Thread Chris Hegarty
-- Original Message - From: chris.hega...@oracle.com To: john.zavg...@oracle.com Cc: kurchi.subhra.ha...@oracle.com, net-dev@openjdk.java.net Sent: Thursday, May 9, 2013 4:39:29 AM GMT -05:00 US/Canada Eastern Subject: Re: RFR JDK7188517 John, I think you can simply reinstate http://hg.openj

Re: RFR JDK7188517

2013-05-31 Thread John Zavgren
racle.com Cc: kurchi.subhra.ha...@oracle.com, net-dev@openjdk.java.net Sent: Thursday, May 9, 2013 4:39:29 AM GMT -05:00 US/Canada Eastern Subject: Re: RFR JDK7188517 John, I think you can simply reinstate http://hg.openjdk.java.net/jdk8/jdk8/jdk/diff/7bd32bfc0539/test/java/net/CookieHandler/TestH

Re: RFR JDK7188517

2013-05-15 Thread Chris Hegarty
On 15/05/2013 13:02, Chris Hegarty wrote: I believe the reviews on the open list are complete. The CCC has been accepted, nut it needs to be make final, then the CCC committee need to vote again. I did send mail to you about making it final ( one step process ), but you may not have seen it

[OFFLIST] Re: RFR JDK7188517

2013-05-15 Thread Chris Hegarty
g...@oracle.com Cc: kurchi.subhra.ha...@oracle.com, net-dev@openjdk.java.net Sent: Thursday, May 9, 2013 4:39:29 AM GMT -05:00 US/Canada Eastern Subject: Re: RFR JDK7188517 John, I think you can simply reinstate http://hg.openjdk.java.net/jdk8/jdk8/jdk/diff/7bd32bfc0539/test/java/ne

Re: RFR JDK7188517

2013-05-15 Thread John Zavgren
.@oracle.com Cc: kurchi.subhra.ha...@oracle.com, net-dev@openjdk.java.net Sent: Thursday, May 9, 2013 4:39:29 AM GMT -05:00 US/Canada Eastern Subject: Re: RFR JDK7188517 John, I think you can simply reinstate http://hg.openjdk.java.net/jdk8/jdk8/jdk/diff/7bd32bfc0539/test/java/net/CookieHandler/TestHttpCook

Re: RFR JDK7188517

2013-05-09 Thread John Zavgren
ginal Message - > From: chris.hega...@oracle.com > To: john.zavg...@oracle.com > Cc: kurchi.subhra.ha...@oracle.com, net-dev@openjdk.java.net > Sent: Thursday, May 9, 2013 4:39:29 AM GMT -05:00 US/Canada Eastern > Subject: Re: RFR JDK7188517 > > John, > > I think you can simp

Re: RFR JDK7188517

2013-05-09 Thread Kurchi Hazra
://cr.openjdk.java.net/~jzavgren/7188517/webrev.03/ John - Original Message - From: chris.hega...@oracle.com To: john.zavg...@oracle.com Cc: kurchi.subhra.ha...@oracle.com, net-dev@openjdk.java.net Sent: Thursday, May 9, 2013 4:39:29 AM GMT -05:00 US/Canada Eastern Subject: Re: RFR JDK7188517

Re: RFR JDK7188517

2013-05-09 Thread Chris Hegarty
...@oracle.com, net-dev@openjdk.java.net Sent: Thursday, May 9, 2013 4:39:29 AM GMT -05:00 US/Canada Eastern Subject: Re: RFR JDK7188517 John, I think you can simply reinstate http://hg.openjdk.java.net/jdk8/jdk8/jdk/diff/7bd32bfc0539/test/java/net/CookieHandler/TestHttpCookie.java -Chris. On 05/08

Re: RFR JDK7188517

2013-05-09 Thread John Zavgren
AM GMT -05:00 US/Canada Eastern Subject: Re: RFR JDK7188517 John, I think you can simply reinstate http://hg.openjdk.java.net/jdk8/jdk8/jdk/diff/7bd32bfc0539/test/java/net/CookieHandler/TestHttpCookie.java -Chris. On 05/08/2013 09:02 PM, Kurchi Hazra wrote: > I would have thrown an except

Re: RFR JDK7188517

2013-05-09 Thread Chris Hegarty
John, I think you can simply reinstate http://hg.openjdk.java.net/jdk8/jdk8/jdk/diff/7bd32bfc0539/test/java/net/CookieHandler/TestHttpCookie.java -Chris. On 05/08/2013 09:02 PM, Kurchi Hazra wrote: I would have thrown an exception if the IllegalArgumentException is not obtained, otherwise the

Re: RFR JDK7188517

2013-05-08 Thread Kurchi Hazra
I would have thrown an exception if the IllegalArgumentException is not obtained, otherwise the test looses its purpose, and will pass silently if someone mistakenly removes the $ check in our code. - Kurchi On 5/8/2013 12:10 PM, John Zavgren wrote: Greetings: I added a test for the leading

Re: RFR JDK7188517

2013-05-08 Thread John Zavgren
Greetings: I added a test for the leading dollar sign character in cookie names: http://cr.openjdk.java.net/~jzavgren/7188517/webrev.03/ Thanks! John On 05/08/2013 08:33 AM, Michael McMahon wrote: On 08/05/13 09:50, Chris Hegarty wrote: On 08/05/2013 10:35, Michael McMahon wrote: On 07/05/1

Re: RFR JDK7188517

2013-05-08 Thread Michael McMahon
On 08/05/13 09:50, Chris Hegarty wrote: On 08/05/2013 10:35, Michael McMahon wrote: On 07/05/13 14:43, Chris Hegarty wrote: On 05/06/2013 10:28 PM, Kurchi Hazra wrote: This looks okay to me. Source changes look fine to me too. Probably best to add a test for '$' In fact, Michael actually re

Re: RFR JDK7188517

2013-05-08 Thread Chris Hegarty
On 08/05/2013 10:35, Michael McMahon wrote: On 07/05/13 14:43, Chris Hegarty wrote: On 05/06/2013 10:28 PM, Kurchi Hazra wrote: This looks okay to me. Source changes look fine to me too. Probably best to add a test for '$' In fact, Michael actually removed such a test [1] during another chan

Re: RFR JDK7188517

2013-05-08 Thread Michael McMahon
On 07/05/13 14:43, Chris Hegarty wrote: On 05/06/2013 10:28 PM, Kurchi Hazra wrote: This looks okay to me. Source changes look fine to me too. Probably best to add a test for '$' In fact, Michael actually removed such a test [1] during another change. We should get positive agreement from Mi

Re: RFR JDK7188517

2013-05-07 Thread Chris Hegarty
On 05/06/2013 10:28 PM, Kurchi Hazra wrote: This looks okay to me. Source changes look fine to me too. Probably best to add a test for '$' In fact, Michael actually removed such a test [1] during another change. We should get positive agreement from Michael before pushing this. -Chris. [1]

Re: RFR JDK7188517

2013-05-06 Thread Kurchi Hazra
This looks okay to me. - Kurchi On 5/2/2013 10:09 AM, John Zavgren wrote: All: My original email was mangled by my email program (stbeehive/zimbra) ... so I'm sending a second correctly formatted copy. I'm sorry for the inconvenience. John --- Please consider the following cha

Re: RFR JDK7188517

2013-05-02 Thread John Zavgren
All: My original email was mangled by my email program (stbeehive/zimbra) ... so I'm sending a second correctly formatted copy. I'm sorry for the inconvenience. John --- Please consider the following change to the cookie constructor: http://cr.openjdk.java.net/~jzavgren/71