Re: RFR JDK-8156693: Improve usability of CompletableFuture use in WebSocket API

2016-06-08 Thread Roger Riggs
+1, Thanks, Roger On 6/8/2016 9:13 AM, Pavel Rappo wrote: On 7 Jun 2016, at 18:42, Roger Riggs wrote: Hi Pavel, Looks fine. WebSocket.java: - line 82: I'd replace 'never' with 'does not'; it is more like a statement for fact and less a guarantee. - LIne 54: The notation "{@code .onX}" se

Re: RFR JDK-8156693: Improve usability of CompletableFuture use in WebSocket API

2016-06-08 Thread Pavel Rappo
> On 7 Jun 2016, at 18:42, Roger Riggs wrote: > > Hi Pavel, > > Looks fine. > > WebSocket.java: > - line 82: I'd replace 'never' with 'does not'; it is more like a statement > for fact and less a guarantee. > > - LIne 54: The notation "{@code .onX}" seems unnecessary, is quite cryptic, > a

Re: RFR JDK-8156693: Improve usability of CompletableFuture use in WebSocket API

2016-06-07 Thread Roger Riggs
Hi Pavel, Looks fine. WebSocket.java: - line 82: I'd replace 'never' with 'does not'; it is more like a statement for fact and less a guarantee. - LIne 54: The notation "{@code .onX}" seems unnecessary, is quite cryptic, and can be removed. Are there any tests that would be updated to g