On 18/04/16 15:30, Pavel Rappo wrote:
On 13 Apr 2016, at 10:10, Chris Hegarty wrote:
A general comment; Quite a number of classes, especially Encoder and Decoder,
would benefit from a few relatively lightweight comments, e.g. IntegerReader
I would like to address it after the initial push.
> On 13 Apr 2016, at 10:10, Chris Hegarty wrote:
>
> A general comment; Quite a number of classes, especially Encoder and Decoder,
> would benefit from a few relatively lightweight comments, e.g. IntegerReader
I would like to address it after the initial push. If possible. Other than that,
I ha
Pavel,
Overall this is very good. I have mostly minor comments.
> Though this is an implementation only package, it could use a few more
> comments
> to support maintainers. In the package.html, a couple of hints about what
> classes are
> the external interface would be useful and an example
> On 12 Apr 2016, at 19:47, Chris Hegarty wrote:
>
>>> On 12 Apr 2016, at 16:56, Roger Riggs wrote:
>>>
>>> Since you have a TestHelper class you could put it there and not duplicate
>>> the code in several tests.
>>
>> Thanks! Done.
>>
>> http://cr.openjdk.java.net/~prappo/8153353/webrev.0
On 12 Apr 2016, at 17:51, Pavel Rappo wrote:
>
>> On 12 Apr 2016, at 16:56, Roger Riggs wrote:
>>
>> Since you have a TestHelper class you could put it there and not duplicate
>> the code in several tests.
>
> Thanks! Done.
>
> http://cr.openjdk.java.net/~prappo/8153353/webrev.00/test/java
> On 12 Apr 2016, at 16:56, Roger Riggs wrote:
>
> Since you have a TestHelper class you could put it there and not duplicate
> the code in several tests.
Thanks! Done.
http://cr.openjdk.java.net/~prappo/8153353/webrev.00/test/java/net/httpclient/http2/java.httpclient/sun/net/httpclient/hpack
Hi Pavel,
On 4/12/2016 10:36 AM, Pavel Rappo wrote:
Hi Roger, thanks for looking into this!
Changes are done in-place.
It saves hunting around if you provide the link.
http://cr.openjdk.java.net/~prappo/8153353/webrev.00/
Do you think issues marked as [*] could be addressed incrementally a
Hi Roger, thanks for looking into this!
Changes are done in-place.
Do you think issues marked as [*] could be addressed incrementally after the
initial push?
> On 11 Apr 2016, at 16:18, Roger Riggs wrote:
>
> Hi Pavel,
>
> Though this is an implementation only package, it could use a few mor
Hi Pavel,
Though this is an implementation only package, it could use a few more
comments
to support maintainers. In the package.html, a couple of hints about
what classes are
the external interface would be useful and an example of use in Encode
and/or Decode
would help a lot.
The tests u
On Wednesday, April 6, 2016, Pavel Rappo wrote:
> Hi again Simone :-)
>
> > On 6 Apr 2016, at 20:31, Simone Bordet > wrote:
> >
> > 1) Add a test for the decoder where you have the incoming bytes be
> > passed 1 at the time to the decoder.
> > Something like:
> >
> > ByteBuffer data = ByteBuffer
Hi again Simone :-)
> On 6 Apr 2016, at 20:31, Simone Bordet wrote:
>
> 1) Add a test for the decoder where you have the incoming bytes be
> passed 1 at the time to the decoder.
> Something like:
>
> ByteBuffer data = ByteBuffer.wrap(new byte[]{
>0b, // literal, index=15
Hi,
On Wed, Apr 6, 2016 at 8:00 PM, Pavel Rappo wrote:
> Hi,
>
> Could you please review my change for JDK-8153353?
>
> http://cr.openjdk.java.net/~prappo/8153353/webrev.00/
>
> This is an implementation of HPACK (Header Compression for HTTP/2) [1]
> Internal API classes are (package sun.net.http
12 matches
Mail list logo
