Re: RFR JDK-8008972

2013-05-31 Thread Dmitry Samersoff
John, Looks good for me. -Dmitry On 2013-05-31 21:06, John Zavgren wrote: > All: > I have a revised webrev image that's ready for review: > http://cr.openjdk.java.net/~jzavgren/8008972/webrev.04/ > > Thanks > John > > On 05/13/2013 04:14 PM, John Zavgren wrote: >> Greetings: >> I posted a new

Re: RFR JDK-8008972

2013-05-31 Thread Alan Bateman
On 31/05/2013 19:54, John Zavgren wrote: Alan: There are two parameters involved here that have similar names: MAX_PACKET_LEN and MAX_BUFFER_LEN. If the code receives a "jumbo" packet (larger than MAX_PACKET_LEN) then the length is truncated to MAX_PACKET_LEN before the next step. In that "

Re: RFR JDK-8008972

2013-05-31 Thread Alan Bateman
On 31/05/2013 18:06, John Zavgren wrote: All: I have a revised webrev image that's ready for review: http://cr.openjdk.java.net/~jzavgren/8008972/webrev.04/ There's something not quite right here, it looks to me that packetBufferLen will always be truncated to MAX_PACKET_LEN to therefore the m

Re: RFR JDK-8008972

2013-05-31 Thread Chris Hegarty
This looks fine to me John. Thanks for persisting with me to get thus done. -Chris On 31 May 2013, at 18:06, John Zavgren wrote: > All: > I have a revised webrev image that's ready for review: > http://cr.openjdk.java.net/~jzavgren/8008972/webrev.04/ > > Thanks > John > > On 05/13/2013 04:14

Re: RFR JDK-8008972

2013-05-31 Thread John Zavgren
All: I have a revised webrev image that's ready for review: http://cr.openjdk.java.net/~jzavgren/8008972/webrev.04/ Thanks John On 05/13/2013 04:14 PM, John Zavgren wrote: Greetings: I posted a new webrev image: http://cr.openjdk.java.net/~jzavgren/8008972/webrev.03/ that fixes a memory leak.

Re: RFR JDK-8008972

2013-05-13 Thread John Zavgren
Greetings: I posted a new webrev image: http://cr.openjdk.java.net/~jzavgren/8008972/webrev.03/ that fixes a memory leak. The leak in src/windows/native/java/net/DualStackPlainDatagramSocketImpl.c is caused by an unfortunate interplay between two actions: 1.) dynamically allocating a larger pa

Re: RFR JDK-8008972

2013-03-04 Thread Chris Hegarty
not. A similar potential memory leak occurs in the "companion" file: src/windows/native/java/net/TwoStacksPlainDatagramSocketImpl.c I hope this helps. John - Original Message - From: chris.hega...@oracle.com To: net-dev@openjdk.java.net, john.zavg...@oracle.com Sent: Monday, M

Re: RFR JDK-8008972

2013-03-04 Thread John Zavgren
hn.zavg...@oracle.com Sent: Monday, March 4, 2013 1:17:31 PM GMT -05:00 US/Canada Eastern Subject: Re: RFR JDK-8008972 On 03/04/2013 04:28 PM, John Zavgren wrote: > Greetings: > > I've posted a webrev image of a memory leak fix: > http://cr.openjdk.java.net/~jzavgren/8008972/webrev.01/

Re: RFR JDK-8008972

2013-03-04 Thread Chris Hegarty
On 03/04/2013 04:28 PM, John Zavgren wrote: Greetings: I've posted a webrev image of a memory leak fix: http://cr.openjdk.java.net/~jzavgren/8008972/webrev.01/ Sorry John, I don't see what the problem is that you are trying to solve? Can you please explain why the original code has problems?