Daniel and Chris,
thanks for the comment, I will push the updated version.
Thanks,
Felix
On 2016/11/2 22:12, Daniel Fuchs wrote:
On 02/11/16 11:18, Chris Hegarty wrote:
Thanks for doing this Felix.
I have some comments about the style and the use of
AccessControlContext.
Rather than list
On 02/11/16 11:18, Chris Hegarty wrote:
Thanks for doing this Felix.
I have some comments about the style and the use of AccessControlContext.
Rather than list them I put an alternative version at the following location,
please
take a look.
http://cr.openjdk.java.net/~chegar/8156504_alt/
No
Thanks for doing this Felix.
I have some comments about the style and the use of AccessControlContext.
Rather than list them I put an alternative version at the following location,
please
take a look.
http://cr.openjdk.java.net/~chegar/8156504_alt/
Note: specifically it is good practice to r
Hi Amy,
thanks for the comments. Updated webrev:
http://cr.openjdk.java.net/~xiaofeya/8156504/webrev.01/
-Felix
On 2016/11/2 14:18, Amy Lu wrote:
Good to see one more script test be changed to java, thank you Felix.
I'm not official reviewer, but some minor comments.
30 * @library /li
Good to see one more script test be changed to java, thank you Felix.
I'm not official reviewer, but some minor comments.
30 * @library /lib/testlibrary
31 * @build jdk.testlibrary.*
32 * @compile LookupTest.java
I noticed test requires testlibrary, but seems test do not actually
depen
