Hi Felix,
This looks good to me now.
best regards,
-- daniel
On 26/09/16 15:02, Felix Yang wrote:
Hi Daniel,
thanks for figuring out this mistake. Put it before return to avoid
unclosed socket. Also updated style as Langer suggested.
Updated web rev:
http://cr.openjdk.java.net/~xi
Hi Daniel,
thanks for figuring out this mistake. Put it before return to avoid
unclosed socket. Also updated style as Langer suggested.
Updated web rev:
http://cr.openjdk.java.net/~xiaofeya/8085575_8130657/webrev.01/
Thanks,
Felix
> On 26 Sep 2016, at 5:29 PM, Daniel Fuchs wrote:
>
>
Xuelei,
thanks for the information. That is why I stated it is the nature of such
scenario. Some of such scenarios look like not avoidable.
Thanks,
Felix
> On 26 Sep 2016, at 5:57 PM, Xuelei Fan wrote:
>
> Just FYI.
>
> The intermittent failures look like similar to some anti-free-port usi
Just FYI.
The intermittent failures look like similar to some anti-free-port using
issues. In the current testing environment, for the InheritHandle test
case, this anti-free-port using issue may looks like:
1. InheritHandle creates a server socket on a free port, and gets the
port (PORT-A)
Hi Felix,
InheritHandle.java:
79 } finally {
80 try {
81 ss.close();
82 } catch (IOException e) {
83 e.printStackTrace();
84 }
85 }
Is finally the right construct here? It seems to me that
you're c
Hi Felix,
looks ok to me, though I'm no reviewer.
One nit: test/java/net/MulticastSocket/TimeToLive.java, line 40, you could
remove the ';' from the try statement.
Best regards
Christoph
> -Original Message-
> From: net-dev [mailto:net-dev-boun...@openjdk.java.net] On Behalf Of Felix
>
