Re: RFR 8078219: Verify lack of @test tag in files in java/net test directory

2019-08-21 Thread Patrick Concannon
Ok, I will fix before pushing! On 21/08/2019 13:09, Alan Bateman wrote: y prefer "static final" over "final static".

Re: RFR 8078219: Verify lack of @test tag in files in java/net test directory

2019-08-21 Thread Alan Bateman
On 21/08/2019 12:03, Patrick Concannon wrote: Hi, Thanks Alan for the suggestions. I've made those changes below: http://cr.openjdk.java.net/~aefimov/pconcann/8078219/01/ This looks okay to me. Just a minor nit in GetURLsTest where we usually prefer "static final" over "final static". -Ala

Re: RFR 8078219: Verify lack of @test tag in files in java/net test directory

2019-08-21 Thread Patrick Concannon
Hi, Thanks Alan for the suggestions. I've made those changes below: http://cr.openjdk.java.net/~aefimov/pconcann/8078219/01/ Kind regards, Patrick On 20/08/2019 15:44, Alan Bateman wrote: On 20/08/2019 15:27, Patrick Concannon wrote: Hi, Would it be possible to have my fix for JDK-80

Re: RFR 8078219: Verify lack of @test tag in files in java/net test directory

2019-08-20 Thread Alan Bateman
On 20/08/2019 15:27, Patrick Concannon wrote: Hi, Would it be possible to have my fix for JDK-8078219 reviewed? Several tests in java.net were found to be missing their JTReg @test tags: 1. test/jdk/java/net/MulticastSocket/Reuse.java -- Test tag added. Test worked as expected 2. test