On 2017-01-25 13:51, Chris Hegarty wrote:
On 24 Jan 2017, at 16:44, Erik Joelsson wrote:
Hello,
Build changes look good except for one thing. In Javadoc.gmk, the dependency on
$(BUILD_TOOLS_JDK) needs to be set for $$($1_INDEX_FILE) (on line 317), where
the actual recipes are created. Settin
Thanks, looks good now.
/Erik
On 2017-01-25 13:51, Chris Hegarty wrote:
On 24 Jan 2017, at 16:44, Erik Joelsson wrote:
Hello,
Build changes look good except for one thing. In Javadoc.gmk, the dependency on
$(BUILD_TOOLS_JDK) needs to be set for $$($1_INDEX_FILE) (on line 317), where
the a
> On 24 Jan 2017, at 16:44, Erik Joelsson wrote:
>
> Hello,
>
> Build changes look good except for one thing. In Javadoc.gmk, the dependency
> on $(BUILD_TOOLS_JDK) needs to be set for $$($1_INDEX_FILE) (on line 317),
> where the actual recipes are created. Setting it on the phony docs-javado
Hi Chris
As regards the networking changes, they look fine to me.
As discussed off list, I think the link generated by the @Incubating
tag might possibly point to a new page in the docs bundle rather than
directly to the JEP 11 page. But, that can be the subject of another change.
Thanks,
Micha
Hello,
Build changes look good except for one thing. In Javadoc.gmk, the
dependency on $(BUILD_TOOLS_JDK) needs to be set for $$($1_INDEX_FILE)
(on line 317), where the actual recipes are created. Setting it on the
phony docs-javadoc target will not help incremental builds.
/Erik
On 2017-0
