Re: RFR-JDK8012108

2013-04-29 Thread Chris Hegarty
.zavg...@oracle.com Cc:dmitry.samers...@oracle.com Sent: Friday, April 19, 2013 8:59:25 AM GMT -05:00 US/Canada Eastern Subject: Re: RFR-JDK8012108 On 18/04/2013 22:11, Dmitry Samersoff wrote: John, I see bad realloc pattern here. Could you fix it as well? Yes, please. Otherwise the changes look fine.

Re: RFR-JDK8012108

2013-04-26 Thread Chris Hegarty
: RFR-JDK8012108 On 18/04/2013 22:11, Dmitry Samersoff wrote: John, I see bad realloc pattern here. Could you fix it as well? Yes, please. Otherwise the changes look fine. -Chris. e.g. 93 adapterInfo = (IP_ADAPTER_ADDRESSES *) realloc (adapterInfo, len); -Dmitry On 2013-04-19 00:56

Re: RFR-JDK8012108

2013-04-25 Thread John Zavgren
//cr.openjdk.java.net/~jzavgren/8012108/webrev.02/ Thanks! John Z - Original Message - From:chris.hega...@oracle.com To:net-dev@openjdk.java.net,john.zavg...@oracle.com Cc:dmitry.samers...@oracle.com Sent: Friday, April 19, 2013 8:59:25 AM GMT -05:00 US/Canada Eastern Subject: Re: RFR-JDK80121

Re: RFR-JDK8012108

2013-04-25 Thread Dmitry Samersoff
l. >>>> >>>> >>>> >>>> >>>> >>>>> -Dmitry >>>>> >>>>> >>>>> On 2013-04-20 01:33, John Zavgren wrote: >>>>>> Greetings: >>>>>> >>>>

Re: RFR-JDK8012108

2013-04-24 Thread John Zavgren
S/Canada Eastern Subject: Re: RFR-JDK8012108 On 18/04/2013 22:11, Dmitry Samersoff wrote: John, I see bad realloc pattern here. Could you fix it as well? Yes, please. Otherwise the changes look fine. -Chris. e.g. 93 adapterInfo = (IP_ADAPTER_ADDRESSES *) realloc (adapterInfo, len); -Dmitry

Re: RFR-JDK8012108

2013-04-24 Thread Dmitry Samersoff
>>>> -Dmitry >>>> >>>> >>>> On 2013-04-20 01:33, John Zavgren wrote: >>>>> Greetings: >>>>> >>>>> I fixed the bad realloc pattern. Please let me know what you think. >>>>> http://cr.openjdk.java.net/~jzavgre

Re: RFR-JDK8012108

2013-04-24 Thread John Zavgren
...@oracle.com Cc: dmitry.samers...@oracle.com Sent: Friday, April 19, 2013 8:59:25 AM GMT -05:00 US/Canada Eastern Subject: Re: RFR-JDK8012108 On 18/04/2013 22:11, Dmitry Samersoff wrote: John, I see bad realloc pattern here. Could you fix it as well? Yes, please. Otherwise the changes look fine. -C

Re: RFR-JDK8012108

2013-04-20 Thread Kurchi Subhra Hazra
>> >>>> Thanks! >>>> John Z >>>> >>>> >>>> - Original Message - >>>> From: chris.hega...@oracle.com >>>> To: net-dev@openjdk.java.net, john.zavg...@oracle.com >>>> Cc: dmitry.samers..

Re: RFR-JDK8012108

2013-04-20 Thread Dmitry Samersoff
/cr.openjdk.java.net/~jzavgren/8012108/webrev.02/ >>> >>> Thanks! >>> John Z >>> >>> >>> - Original Message - >>> From: chris.hega...@oracle.com >>> To: net-dev@openjdk.java.net, john.zavg...@oracle.com >>> C

Re: RFR-JDK8012108

2013-04-20 Thread Kurchi Subhra Hazra
gt;> >> >> - Original Message - >> From: chris.hega...@oracle.com >> To: net-dev@openjdk.java.net, john.zavg...@oracle.com >> Cc: dmitry.samers...@oracle.com >> Sent: Friday, April 19, 2013 8:59:25 AM GMT -05:00 US/Canada Eastern >> Subject:

Re: RFR-JDK8012108

2013-04-20 Thread Dmitry Samersoff
; Thanks! > John Z > > > - Original Message - > From: chris.hega...@oracle.com > To: net-dev@openjdk.java.net, john.zavg...@oracle.com > Cc: dmitry.samers...@oracle.com > Sent: Friday, April 19, 2013 8:59:25 AM GMT -05:00 US/Canada Eastern > Subject: Re: RF

Re: RFR-JDK8012108

2013-04-20 Thread Chris Hegarty
://cr.openjdk.java.net/~jzavgren/8012108/webrev.02/ Thanks! John Z - Original Message - From:chris.hega...@oracle.com To:net-dev@openjdk.java.net,john.zavg...@oracle.com Cc:dmitry.samers...@oracle.com Sent: Friday, April 19, 2013 8:59:25 AM GMT -05:00 US/Canada Eastern Subject: Re: RFR

Re: RFR-JDK8012108

2013-04-19 Thread Kurchi Subhra Hazra
: Re: RFR-JDK8012108 On 18/04/2013 22:11, Dmitry Samersoff wrote: John, I see bad realloc pattern here. Could you fix it as well? Yes, please. Otherwise the changes look fine. -Chris. e.g. 93 adapterInfo = (IP_ADAPTER_ADDRESSES *) realloc (adapterInfo, len); -Dmitry On 2013-04-19 00:56

Re: RFR-JDK8012108

2013-04-19 Thread John Zavgren
...@oracle.com Sent: Friday, April 19, 2013 8:59:25 AM GMT -05:00 US/Canada Eastern Subject: Re: RFR-JDK8012108 On 18/04/2013 22:11, Dmitry Samersoff wrote: > John, > > I see bad realloc pattern here. Could you fix it as well? Yes, please. Otherwise the changes look fine. -Chris. > &

Re: RFR-JDK8012108

2013-04-19 Thread Chris Hegarty
On 18/04/2013 22:11, Dmitry Samersoff wrote: John, I see bad realloc pattern here. Could you fix it as well? Yes, please. Otherwise the changes look fine. -Chris. e.g. 93 adapterInfo = (IP_ADAPTER_ADDRESSES *) realloc (adapterInfo, len); -Dmitry On 2013-04-19 00:56, John Zavgren wro

Re: RFR-JDK8012108

2013-04-18 Thread Kurchi Hazra
Thanks John, I think the leak is taken care of now, I can sponsor the change for you once you have a thumbs up from everyone. - Kurchi On 4/18/2013 1:56 PM, John Zavgren wrote: Greetings: I fixed a case in the windows native code where calloc() was being used without checking it's returned v

Re: RFR-JDK8012108

2013-04-18 Thread Dmitry Samersoff
John, I see bad realloc pattern here. Could you fix it as well? e.g. 93 adapterInfo = (IP_ADAPTER_ADDRESSES *) realloc (adapterInfo, len); -Dmitry On 2013-04-19 00:56, John Zavgren wrote: > Greetings: > > I fixed a case in the windows native code where calloc() was being used > without ch