On 14/08/2020 16:48, Conor Cleary wrote:
Thanks for the suggestion Daniel, looks much nicer without the casting
in the immutableCopy function as well!
I made a new patch with those reverted changes and it looks much nicer
and still behaves as expected.
webrev:
http://cr.openjdk.java.net/~cc
> On 14 Aug 2020, at 16:48, Conor Cleary wrote:
>
> Thanks for the suggestion Daniel, looks much nicer without the casting in the
> immutableCopy function as well!
>
> I made a new patch with those reverted changes and it looks much nicer and
> still behaves as expected.
>
> webrev:
> htt
Thanks for the suggestion Daniel, looks much nicer without the casting
in the immutableCopy function as well!
I made a new patch with those reverted changes and it looks much nicer
and still behaves as expected.
webrev:
http://cr.openjdk.java.net/~ccleary/issues/webrevs-store/8246047/webrevs
Hi Conor,
Thanks for addressing this technical debt.
I don't think this is correct. You transformed the immutable
copy at line 137 into a shallow clone, since now both copies
share the same mutable list.
I suggest to revert the changes at lines:
66,67,144 and 145.
(and that will be much simpl
Hi all,
Requesting some reviewers for a patch concerning JDK-8246047 'Replace
LinkedList impl in net.http.websocket.BuilderImpl'. This patch replaces
LinkedList data structures used in the net.http.websocket BuilderImpl
class with ArrayLists. In particular, the 'headers' and 'subprotocols'
Co
