On 27/01/2020 17:27, Patrick Concannon wrote:
I’ve taken the @throws IAE from DatagramPacket::getSocketAddress, and
logged it as a separate issue as it seems further work is needed in
deciding how to move forward with it. See
https://bugs.openjdk.java.net/browse/JDK-8237890
Thanks for sep
Hi,
Thanks everyone for the feedback.
Chris, I've incorporated the changes you asked for, and they can be
found in the updated webrev here:
http://cr.openjdk.java.net/~pconcannon/7021373/webrevs/webrev.01/
I’ve taken the @throws IAE from DatagramPacket::getSocketAddress, and
logged it as a
On 24/01/2020 15:16, Chris Hegarty wrote:
:
Can we please have a class-level specification of whatthe
valid port range is; 0 <= port <= 0x? This should be
verifiable .
I agree this would be useful to have and it could be linked to from the
various places that mention the range.
-Alan
Maybe we can retain existing behaviour, while implicitly specifying the IAE?
@@ -311,16 +312,21 @@
setAddress(addr.getAddress());
setPort(addr.getPort());
}
/**
* Gets the SocketAddress (usually IP address + port number) of the remote
* host that this pac
On 24/01/2020 12:07, Chris Hegarty wrote:
Patrick,
On 24/01/2020 11:14, Patrick Concannon wrote:
Hi,
Could someone please review my fix and CSR for issue JDK-7021373
'DatagramPacket exception conditions are not clear' ?
This fix updates the spec concerning the exceptions thrown by the
c
On 24/01/2020 11:49, Daniel Fuchs wrote:
If I'm not mistaken, one side effect here is that this allows
the DatagramSocketAdaptor to throw IllegalArgumentException when
it is not connected and passed a DatagramPacket in which the port
as not been set.
Yes, that's the outlier I mentioned in the re
Patrick,
On 24/01/2020 11:14, Patrick Concannon wrote:
Hi,
Could someone please review my fix and CSR for issue JDK-7021373
'DatagramPacket exception conditions are not clear' ?
This fix updates the spec concerning the exceptions thrown by the
constructors of the DatagramPacket class, and s
Hi Alan,
On 24/01/2020 11:41, Alan Bateman wrote:
CSR: https://bugs.openjdk.java.net/browse/JDK-8237774
webrev: http://cr.openjdk.java.net/~pconcannon/7021373/webrevs/webrev.00/
I just skimmed over this (not a complete review) but getSocketAddress()
throwing IllegalArgumentException doesn't str
On 24/01/2020 11:14, Patrick Concannon wrote:
Hi,
Could someone please review my fix and CSR for issue JDK-7021373
'DatagramPacket exception conditions are not clear' ?
This fix updates the spec concerning the exceptions thrown by the
constructors of the DatagramPacket class, and several met
