Hi Ravi,
Latest changes looks good to me.
Thanks,
Vyom
- Original message -From: Ravi Reddy Sent by: "net-dev" To: Daniel Fuchs , Vyom Tiwari Cc: net-dev Subject: [EXTERNAL] RE: RFR[15] JDK-8183369 : RFC unconformity of HttpURLConnection with proxyDate: Mon, Mar 2, 2020 8:32 PM
Hi Da
Ravi,
> On 2 Mar 2020, at 15:01, Ravi Reddy wrote:
>
> Hi Daniel,
>
> As suggested by you I have added a test case for retry connection with proxy
> case . Please review the latest webrev and let me know your comments.
>
> With the latest changes , the HttpURLConWithProxy test fails without t
Cc: net-dev
Subject: RE: RFR[15] JDK-8183369 : RFC unconformity of HttpURLConnection with
proxy
Hi Daniel/Vyom,
As mentioned in the review comments ,
Change in test case HttpURLConWithProxy.java is to make sure we don’t throw
an error “Can’t use direct connection” even when the connection is
/webrev.00/
Issue: https://bugs.openjdk.java.net/browse/JDK-8183369
Thanks,
Ravi
-Original Message-
From: Ravi Reddy
Sent: Thursday, February 13, 2020 10:10 PM
To: Daniel Fuchs ; Vyom Tiwari
Cc: net-dev
Subject: RE: RFR[15] JDK-8183369 : RFC unconformity of HttpURLConnection with
proxy
Hi
garty
; net-dev
Subject: Re: RFR[15] JDK-8183369 : RFC unconformity of HttpURLConnection with
proxy
Thanks Vyom.
I was suspecting as much.
Ravi, could you come up with a test that fails without the fix and pass with it?
best regards,
-- daniel
On 13/02/2020 14:26, Vyom Tiwari wrote:
>
Thanks Vyom.
I was suspecting as much.
Ravi, could you come up with a test that fails without the fix
and pass with it?
best regards,
-- daniel
On 13/02/2020 14:26, Vyom Tiwari wrote:
Hi Ravi/Daniel,
At my local env(REL 7) test is passing without fix as well. Although my
local repo contai
Hi Ravi/Daniel,
At my local env(REL 7) test is passing without fix as well. Although my
local repo contain some additional code changes but it is not related with
the current fix.
Test1 Passed with: Connect timed out
Test2 Passed with: Connect timed out
##
Please
Hi,
On 13/02/2020 10:52, Ravi Reddy wrote:
I notice that the `break` from the original code has not been
reintroduced. I don't think that it is strictly needed, but did you give
it any consideration?
Chris , in original code since we were doing retry with direct
connection and not proceeding
Hi Chris,
From: Chris Hegarty
Sent: Thursday, February 13, 2020 3:07 PM
To: Ravi Reddy
Cc: net-dev@openjdk.java.net
Subject: Re: RFR[15] JDK-8183369 : RFC unconformity of HttpURLConnection with
proxy
Hi Ravi,
On 5 Feb 2020, at 12:43, Ravi Reddy mailto:ravi.k.re...@oracle.com
Hi Ravi,
> On 5 Feb 2020, at 12:43, Ravi Reddy wrote:
>
> Hello All,
>
> Could you please review this patch. This patch fixes the RFC unconformity of
> HttpURLConnection with proxy issue.
>
> 1.Change in HttpURLConnection.java is to make sure we do retry with proxy as
> mentioned in RFC
>
Hi,
Please do review the below webrev.
Thanks,
Ravi
From: Ravi Reddy
Sent: Wednesday, February 5, 2020 6:13 PM
To: net-dev@openjdk.java.net
Subject: RFR[15] JDK-8183369 : RFC unconformity of HttpURLConnection with proxy
Hello All,
Could you please review this patch. This pa
11 matches
Mail list logo
