Re: RFR: JDK-8275518: accessibility issue in Inet6Address docs [v2]

2021-10-28 Thread Jonathan Gibbons
On Thu, 28 Oct 2021 12:11:33 GMT, Ludvig Janiuk wrote: >> Single-row table was being used for visual effect, but a description list >> seems more appropriate. > > Ludvig Janiuk has updated the pull request incrementally with one additional > commit since the last revision: > > Removed html f

Re: RFR: JDK-8275518: accessibility issue in Inet6Address docs

2021-10-28 Thread Ludvig Janiuk
On Tue, 19 Oct 2021 13:50:20 GMT, Ludvig Janiuk wrote: > Single-row table was being used for visual effect, but a description list > seems more appropriate. Done. I'm happy to drop them, I was just trying to keep the visuals as close to the original as possible. ![image](https://user-images.gi

Re: RFR: JDK-8275518: accessibility issue in Inet6Address docs [v2]

2021-10-28 Thread Ludvig Janiuk
> Single-row table was being used for visual effect, but a description list > seems more appropriate. Ludvig Janiuk has updated the pull request incrementally with one additional commit since the last revision: Removed html fluff - Changes: - all: https://git.openjdk.java.net/

Re: RFR: JDK-8275518: accessibility issue in Inet6Address docs

2021-10-27 Thread Jonathan Gibbons
On Tue, 19 Oct 2021 13:50:20 GMT, Ludvig Janiuk wrote: > Single-row table was being used for visual effect, but a description list > seems more appropriate. OK, but ... While the basic translation from a single-row table to a definition list looks good, it's not clear you still need the `styl

Re: RFR: JDK-8275518: accessibility issue in Inet6Address docs

2021-10-26 Thread Ludvig Janiuk
On Tue, 26 Oct 2021 12:44:38 GMT, Pavel Rappo wrote: >> Single-row table was being used as a hack here, a description list >> seems more appropriate > > Would it be possible to build documentation for that page to see how it looks? @pavelrappo here's a screengrab from my local build. It doesn't

Re: RFR: JDK-8275518: accessibility issue in Inet6Address docs

2021-10-26 Thread Daniel Fuchs
On Tue, 19 Oct 2021 13:50:20 GMT, Ludvig Janiuk wrote: > Single-row table was being used as a hack here, a description list > seems more appropriate Hi Ludwik, it's the first time I see ``, ``, and `` being used in API documentation so I'd like to see some confirmation from the javadoc team th

Re: RFR: JDK-8275518: accessibility issue in Inet6Address docs

2021-10-26 Thread Pavel Rappo
On Tue, 19 Oct 2021 13:50:20 GMT, Ludvig Janiuk wrote: > Single-row table was being used as a hack here, a description list > seems more appropriate Would it be possible to build documentation for that page to see how it looks? - PR: https://git.openjdk.java.net/jdk/pull/6010

Re: RFR: JDK-8275518: accessibility issue in Inet6Address docs

2021-10-26 Thread Magnus Ihse Bursie
On Tue, 19 Oct 2021 13:50:20 GMT, Ludvig Janiuk wrote: > Single-row table was being used as a hack here, a description list > seems more appropriate Looks good to me. - Marked as reviewed by ihse (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/6010