On Thu, 19 May 2022 12:05:45 GMT, Daniel Jeliński wrote:
>> This PR improves the execution time of jdk_net tests (and, by extension,
>> tier2) by about 3 minutes.
>>
>> Tests located under `jdk/java/net/httpclient/websocket` are never run in
>> parallel. Each of the 8 modified `Pending***` tes
On Thu, 19 May 2022 10:46:35 GMT, Pavel Rappo wrote:
> > > What looks questionable is rearrangement of asserts: when `assertHangs`
> > > moves down. assertNotDone(cfClose) can transitorry pass even if ping has
> > > not hung.
> >
> >
> > `assertHangs` either waits for 5 seconds or throws an e
> This PR improves the execution time of jdk_net tests (and, by extension,
> tier2) by about 3 minutes.
>
> Tests located under `jdk/java/net/httpclient/websocket` are never run in
> parallel. Each of the 8 modified `Pending***` tests originally required 40
> seconds to complete. After the prop
On Thu, 19 May 2022 09:42:05 GMT, Daniel Jeliński wrote:
> > What looks questionable is rearrangement of asserts: when `assertHangs`
> > moves down. assertNotDone(cfClose) can transitorry pass even if ping has
> > not hung.
>
> `assertHangs` either waits for 5 seconds or throws an exception, s
> This PR improves the execution time of jdk_net tests (and, by extension,
> tier2) by about 3 minutes.
>
> Tests located under `jdk/java/net/httpclient/websocket` are never run in
> parallel. Each of the 8 modified `Pending***` tests originally required 40
> seconds to complete. After the prop
On Thu, 19 May 2022 09:22:57 GMT, Pavel Rappo wrote:
> What looks questionable is rearrangement of asserts: when `assertHangs` moves
> down. assertNotDone(cfClose) can transitorry pass even if ping has not hung.
`assertHangs` either waits for 5 seconds or throws an exception, so
`assertNotDone
On Tue, 17 May 2022 14:55:11 GMT, Daniel Fuchs wrote:
> I am a bit less sure about moving the post-asserts inside the loop
I moved them because they too can fail if the original blocked future suddenly
completes.
Side effect of this change is that any failures that happen after
websocket.abort
On Tue, 17 May 2022 12:45:52 GMT, Daniel Jeliński wrote:
> This PR improves the execution time of jdk_net tests (and, by extension,
> tier2) by about 3 minutes.
>
> Tests located under `jdk/java/net/httpclient/websocket` are never run in
> parallel. Each of the 8 modified `Pending***` tests or
On Tue, 17 May 2022 12:45:52 GMT, Daniel Jeliński wrote:
> This PR improves the execution time of jdk_net tests (and, by extension,
> tier2) by about 3 minutes.
>
> Tests located under `jdk/java/net/httpclient/websocket` are never run in
> parallel. Each of the 8 modified `Pending***` tests or
