Re: RFR: 8285521: Minor improvements in java.net.URI [v2]

2022-05-20 Thread Сергей Цыпанов
> - use `String.equalsIgnoreCase()` instead of hand-written code relying on > `String.charAt()` > - use `String.compareToIgnoreCase()` instead of hand-written code relying on > `String.charAt()` > - drop branches that are never executed > - drop unused argument from `URI.resolvePath()` > - simpli

Re: RFR: 8285521: Minor improvements in java.net.URI

2022-05-20 Thread Сергей Цыпанов
On Tue, 26 Apr 2022 07:02:55 GMT, Сергей Цыпанов wrote: > - use `String.equalsIgnoreCase()` instead of hand-written code relying on > `String.charAt()` > - use `String.compareToIgnoreCase()` instead of hand-written code relying on > `String.charAt()` > - drop branches that are never executed >

Re: RFR: 8285521: Minor improvements in java.net.URI

2022-05-19 Thread ExE Boss
On Tue, 26 Apr 2022 07:02:55 GMT, Сергей Цыпанов wrote: > - use `String.equalsIgnoreCase()` instead of hand-written code relying on > `String.charAt()` > - use `String.compareToIgnoreCase()` instead of hand-written code relying on > `String.charAt()` > - drop branches that are never executed >

Re: RFR: 8285521: Minor improvements in java.net.URI

2022-05-19 Thread Сергей Цыпанов
On Thu, 19 May 2022 12:19:25 GMT, ExE Boss wrote: >> - use `String.equalsIgnoreCase()` instead of hand-written code relying on >> `String.charAt()` >> - use `String.compareToIgnoreCase()` instead of hand-written code relying on >> `String.charAt()` >> - drop branches that are never executed >>

Re: RFR: 8285521: Minor improvements in java.net.URI

2022-05-19 Thread ExE Boss
On Tue, 26 Apr 2022 07:02:55 GMT, Сергей Цыпанов wrote: > - use `String.equalsIgnoreCase()` instead of hand-written code relying on > `String.charAt()` > - use `String.compareToIgnoreCase()` instead of hand-written code relying on > `String.charAt()` > - drop branches that are never executed >

Re: RFR: 8285521: Minor improvements in java.net.URI

2022-04-26 Thread Daniel Fuchs
On Tue, 26 Apr 2022 12:41:38 GMT, Сергей Цыпанов wrote: > Btw, I see that `java.net.URI` duplicates some methods from > `sun.net.www.ParseUtil`. Should we consolidate them e.g. in a way of reusing > functionality of `sun.net.www.ParseUtil` in `java.net.URI`? I don't think the ratio benefit/ris

Re: RFR: 8285521: Minor improvements in java.net.URI

2022-04-26 Thread Daniel Fuchs
On Tue, 26 Apr 2022 12:39:50 GMT, Сергей Цыпанов wrote: >> src/java.base/share/classes/java/net/URI.java line 1921: >> >>> 1919: return sn - tn; >>> 1920: int val = 0; >>> 1921: int n = Math.min(sn, tn); >> >> Can we drop this change? I wouldn

Re: RFR: 8285521: Minor improvements in java.net.URI

2022-04-26 Thread Сергей Цыпанов
On Tue, 26 Apr 2022 07:02:55 GMT, Сергей Цыпанов wrote: > - use `String.equalsIgnoreCase()` instead of hand-written code relying on > `String.charAt()` > - use `String.compareToIgnoreCase()` instead of hand-written code relying on > `String.charAt()` > - drop branches that are never executed >

Re: RFR: 8285521: Minor improvements in java.net.URI

2022-04-26 Thread Сергей Цыпанов
On Tue, 26 Apr 2022 11:35:10 GMT, Daniel Fuchs wrote: >> - use `String.equalsIgnoreCase()` instead of hand-written code relying on >> `String.charAt()` >> - use `String.compareToIgnoreCase()` instead of hand-written code relying on >> `String.charAt()` >> - drop branches that are never executed

Re: RFR: 8285521: Minor improvements in java.net.URI

2022-04-26 Thread Claes Redestad
On Tue, 26 Apr 2022 11:35:10 GMT, Daniel Fuchs wrote: >> - use `String.equalsIgnoreCase()` instead of hand-written code relying on >> `String.charAt()` >> - use `String.compareToIgnoreCase()` instead of hand-written code relying on >> `String.charAt()` >> - drop branches that are never executed

Re: RFR: 8285521: Minor improvements in java.net.URI

2022-04-26 Thread Daniel Fuchs
On Tue, 26 Apr 2022 07:02:55 GMT, Сергей Цыпанов wrote: > - use `String.equalsIgnoreCase()` instead of hand-written code relying on > `String.charAt()` > - use `String.compareToIgnoreCase()` instead of hand-written code relying on > `String.charAt()` > - drop branches that are never executed >