On Tue, 19 Apr 2022 16:07:29 GMT, Daniel Fuchs wrote:
>> I'm not sure there is value in testing all of these permutations.
>> Distinguishing DatagramChannel and DatagramSocket probably made sense, but
>> it's all the same implementation under the hood.
>
> 1. `DatagramChannel.open()` => opens a
On Tue, 19 Apr 2022 15:54:02 GMT, Michael McMahon wrote:
>> test/jdk/jdk/net/ExtendedSocketOption/DontFragmentTest.java line 44:
>>
>>> 42: StandardProtocolFamily fam = args[0].equals("ipv4") ? INET :
>>> INET6;
>>> 43: System.out.println("Family = " + fam);
>>> 44: test
On Tue, 19 Apr 2022 14:50:57 GMT, Daniel Fuchs wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fix whitespace
>
> src/jdk.net/windows/native/libextnet/WindowsSocketOptions.c line 112:
>
>> 110: retu
On Tue, 19 Apr 2022 14:47:01 GMT, Michael McMahon wrote:
>> Hi,
>>
>> Could I get the following PR review please? It adds a new JDK specific
>> extended socket option
>> called IP_DONTFRAGMENT, which disables IP packet fragmentation in both IPv4
>> and IPv6
>> UDP sockets (NIO DatagramChannels
> Hi,
>
> Could I get the following PR review please? It adds a new JDK specific
> extended socket option
> called IP_DONTFRAGMENT, which disables IP packet fragmentation in both IPv4
> and IPv6
> UDP sockets (NIO DatagramChannels). For IPv4 in particular, it sets the DF
> (Dont Fragment) bit
>
