On Tue, 1 Feb 2022 06:42:30 GMT, Xue-Lei Andrew Fan wrote:
>> Ok. You should specify what the default value of the signature schemes
>> parameter is for this constructor as it does for the other parameters.
>
> Good catch. Updated.
Looks good.
-
PR: https://git.openjdk.java.net/j
On Mon, 31 Jan 2022 21:26:46 GMT, Sean Mullan wrote:
>> As there is increasing number of SSL parameters, applications may just use
>> the constructor with no argument, and use the set methods individually.
>
> Ok. You should specify what the default value of the signature schemes
> parameter is
On Sat, 29 Jan 2022 05:26:33 GMT, Xue-Lei Andrew Fan wrote:
>> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 94:
>>
>>> 92:
>>> 93: /**
>>> 94: * Constructs SSLParameters.
>>
>> Would it be useful to add another ctor that takes a signature schemes array
>> paramet
On Fri, 28 Jan 2022 00:58:37 GMT, Bernd wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Copyright correction
>
> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 763:
>
>> 761:
>> 762:
On Fri, 28 Jan 2022 15:26:56 GMT, Sean Mullan wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Copyright correction
>
> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 94:
>
>> 92:
>> 93:
On Fri, 28 Jan 2022 00:54:53 GMT, Bernd wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Copyright correction
>
> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 92:
>
>> 90: private int
On Fri, 28 Jan 2022 15:50:49 GMT, Jamil Nimeh wrote:
>> You should also define the interaction with the system properties (probably
>> as an @implNote). Does `getSignatureSchemes` ever return the value of the
>> system properties? Does the `setSignatureSchemes` API always override the
>> prope
On Fri, 28 Jan 2022 15:17:25 GMT, Sean Mullan wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Copyright correction
>
> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 709:
>
>> 707: *
On Fri, 28 Jan 2022 15:44:16 GMT, Sean Mullan wrote:
>> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 710:
>>
>>> 708: * Signature Schemes section of the Java Cryptography
>>> 709: * Architecture Standard Algorithm Name Documentation, and may also
>>> 710: * in
On Fri, 28 Jan 2022 15:17:28 GMT, Sean Mullan wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Copyright correction
>
> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 710:
>
>> 708: *
On Fri, 28 Jan 2022 07:21:56 GMT, Xue-Lei Andrew Fan wrote:
>> This update is to support signature schemes customization for individual
>> (D)TLS connection. Please review the CSR as well:
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
>> RFE: https://bugs.openjdk.java.net/browse/JDK-
> This update is to support signature schemes customization for individual
> (D)TLS connection. Please review the CSR as well:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
> RFE: https://bugs.openjdk.java.net/browse/JDK-8280494
Xue-Lei Andrew Fan has updated the pull request increment
On Thu, 27 Jan 2022 23:43:51 GMT, Jie Fu wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Copyright correction
>
> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 3:
>
>> 1: /*
>> 2: * Copy
13 matches
Mail list logo
