Re: RFR: 8275079: Remove unnecessary conversion to String in java.net.http

2021-10-12 Thread Daniel Fuchs
On Sat, 2 Oct 2021 20:05:37 GMT, Andrey Turbanov wrote: > Cleanup unnecessary String.valueOf calls (and similar) when conversion will > happen implicitly anyway LGTM Hi Andrey - I will sponsor this change. - Marked as reviewed by dfuchs (Reviewer). PR: https://git.openjdk.java.n

Re: RFR: 8275079: Remove unnecessary conversion to String in java.net.http

2021-10-11 Thread Andrey Turbanov
On Mon, 4 Oct 2021 13:39:00 GMT, Weijun Wang wrote: >> Cleanup unnecessary String.valueOf calls (and similar) when conversion will >> happen implicitly anyway > > src/java.net.http/share/classes/jdk/internal/net/http/Http1AsyncReceiver.java > line 738: > >> 736: if (flowTag != null

Re: RFR: 8275079: Remove unnecessary conversion to String in java.net.http

2021-10-11 Thread Weijun Wang
On Sat, 2 Oct 2021 20:05:37 GMT, Andrey Turbanov wrote: > Cleanup unnecessary String.valueOf calls (and similar) when conversion will > happen implicitly anyway Some small comments. src/java.net.http/share/classes/jdk/internal/net/http/Http1AsyncReceiver.java line 738: > 736: if