On Fri, 10 Dec 2021 18:18:02 GMT, Andrey Turbanov wrote:
>> This is legacy code with probably poor testing coverage. Usually we don't
>> print anything on the console directly and unconditionally - except in some
>> well identified cases. Ignoring exceptions thrown by `close` is a common
>> id
On Thu, 9 Dec 2021 01:25:20 GMT, Bradford Wetmore wrote:
>> That's one of the places where I personally would always use the var keyword
>> too: it makes the line shorter and the type is already clearly visible in
>> the RHS of the assignment, so repeating it on the left hand side does not
>>
On Tue, 7 Dec 2021 14:48:17 GMT, Daniel Fuchs wrote:
>Remind me to sponsor this after the fork.
fork is done :)
-
PR: https://git.openjdk.java.net/jdk/pull/5818
On Tue, 7 Dec 2021 07:59:54 GMT, Alan Bateman wrote:
>> Andrey Turbanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8274809: Update java.base classes to use try-with-resources
>> fix review comments
>
> src/java.base/share/classes/
> 8274809: Update java.base classes to use try-with-resources
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
8274809: Update java.base classes to use try-with-resources
move { to previous line
-
Changes:
- all: h
On Tue, 7 Dec 2021 14:24:41 GMT, Andrey Turbanov wrote:
>> src/java.base/share/classes/sun/net/www/MimeTable.java line 385:
>>
>>> 383:
>>> 384: protected boolean saveAsProperties(File file) {
>>> 385: try (FileOutputStream os = new FileOutputStream(file)) {
>>
>> This is not stric
On Wed, 6 Oct 2021 20:37:29 GMT, Andrey Turbanov wrote:
>> 8274809: Update java.base classes to use try-with-resources
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8274809: Update java.base classes to use try-with-res
On Tue, 7 Dec 2021 11:41:12 GMT, Daniel Fuchs wrote:
>> Andrey Turbanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8274809: Update java.base classes to use try-with-resources
>> fix review comments
>
> src/java.base/share/classes/
On Wed, 6 Oct 2021 20:37:29 GMT, Andrey Turbanov wrote:
>> 8274809: Update java.base classes to use try-with-resources
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8274809: Update java.base classes to use try-with-res
On Wed, 6 Oct 2021 20:37:29 GMT, Andrey Turbanov wrote:
>> 8274809: Update java.base classes to use try-with-resources
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8274809: Update java.base classes to use try-with-res
On Wed, 6 Oct 2021 16:00:26 GMT, Bradford Wetmore wrote:
>> Andrey Turbanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8274809: Update java.base classes to use try-with-resources
>> fix review comments
>
> src/java.base/share/clas
> 8274809: Update java.base classes to use try-with-resources
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
8274809: Update java.base classes to use try-with-resources
fix review comments
-
Changes:
- all: https
On Wed, 6 Oct 2021 18:47:26 GMT, Andrey Turbanov
wrote:
>> 8274809: Update java.base classes to use try-with-resources
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8274809: Update java.base classes to use try-with-re
On Wed, 6 Oct 2021 18:47:26 GMT, Andrey Turbanov
wrote:
>> 8274809: Update java.base classes to use try-with-resources
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8274809: Update java.base classes to use try-with-re
On Wed, 6 Oct 2021 16:07:12 GMT, Bradford Wetmore wrote:
>> Andrey Turbanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8274809: Update java.base classes to use try-with-resources
>> update copyright year
>
> src/java.base/share/cl
> 8274809: Update java.base classes to use try-with-resources
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
8274809: Update java.base classes to use try-with-resources
update copyright year
-
Changes:
- all: htt
On Wed, 6 Oct 2021 16:11:25 GMT, Bradford Wetmore wrote:
>Files like HttpTimestamper need the copyright dates updated to 2021.
Updated
-
PR: https://git.openjdk.java.net/jdk/pull/5818
On Wed, 6 Oct 2021 16:20:48 GMT, Pavel Rappo wrote:
>> src/java.base/share/classes/sun/security/timestamp/HttpTimestamper.java line
>> 127:
>>
>>> 125: // Receive the reply
>>> 126: byte[] replyBuffer = null;
>>> 127: try (BufferedInputStream input = new
>>> BufferedInp
> 8274809: Update java.base classes to use try-with-resources
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
8274809: Update java.base classes to use try-with-resources
fix post-review comment
-
Changes:
- all: h
On Wed, 6 Oct 2021 16:24:03 GMT, Andrey Turbanov
wrote:
>> src/java.base/share/classes/sun/net/NetProperties.java line 71:
>>
>>> 69: f = new File(f, "net.properties");
>>> 70: fname = f.getCanonicalPath();
>>> 71: try (FileInputStream fis = new FileInputStre
On Wed, 6 Oct 2021 16:00:41 GMT, Bradford Wetmore wrote:
>> 8274809: Update java.base classes to use try-with-resources
>
> src/java.base/share/classes/sun/security/timestamp/HttpTimestamper.java line
> 127:
>
>> 125: // Receive the reply
>> 126: byte[] replyBuffer = null;
>> 12
On Wed, 6 Oct 2021 16:04:54 GMT, Bradford Wetmore wrote:
>> 8274809: Update java.base classes to use try-with-resources
>
> src/java.base/share/classes/sun/net/NetProperties.java line 71:
>
>> 69: f = new File(f, "net.properties");
>> 70: fname = f.getCanonicalPath();
>>
On Tue, 5 Oct 2021 09:36:23 GMT, Andrey Turbanov
wrote:
> 8274809: Update java.base classes to use try-with-resources
I checked the rest. The one BufferedInputStream change is puzzling. Please
explain or address.
Files like HttpTimestamper need the copyright dates updated to 2021.
src/java
On Tue, 5 Oct 2021 09:36:23 GMT, Andrey Turbanov
wrote:
> 8274809: Update java.base classes to use try-with-resources
Reviewed the crypto/security files.
src/java.base/share/classes/sun/security/timestamp/HttpTimestamper.java line
115:
> 113:
> 114: // Send the request
> 115:
On Tue, 5 Oct 2021 09:36:23 GMT, Andrey Turbanov
wrote:
> 8274809: Update java.base classes to use try-with-resources
The security related files look fine.
-
Marked as reviewed by mullan (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/5818
25 matches
Mail list logo
