Re: RFR: 8273243: Fix indentations in java.net.InetAddress methods [v2]

2021-09-02 Thread Daniel Fuchs
On Wed, 1 Sep 2021 23:11:53 GMT, Aleksei Efimov wrote: >> Hi, >> >> The fix changes indentations in the following `java.net.InetAddress` methods: >> - getAddressesFromNameService >> - getHostFromNameService >> >> It helps to improve code readability. Can't say the same about >> `getHostFromNam

Re: RFR: 8273243: Fix indentations in java.net.InetAddress methods [v2]

2021-09-01 Thread Aleksei Efimov
> Hi, > > The fix changes indentations in the following `java.net.InetAddress` methods: > - getAddressesFromNameService > - getHostFromNameService > > It helps to improve code readability. Can't say the same about > `getHostFromNameService` diffs shown in this PR. Aleksei Efimov has updated the

Re: RFR: 8273243: Fix indentations in java.net.InetAddress methods [v2]

2021-09-01 Thread Aleksei Efimov
On Wed, 1 Sep 2021 17:08:24 GMT, Brian Burkhalter wrote: >> Aleksei Efimov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8273243: looks -> looks like > > src/java.base/share/classes/java/net/InetAddress.java line 689: > >> 687:

Re: RFR: 8273243: Fix indentations in java.net.InetAddress methods

2021-09-01 Thread Daniel Fuchs
On Wed, 1 Sep 2021 16:53:50 GMT, Aleksei Efimov wrote: > Hi, > > The fix changes indentations in the following `java.net.InetAddress` methods: > - getAddressesFromNameService > - getHostFromNameService > > It helps to improve code readability. Can't say the same about > `getHostFromNameService

Re: RFR: 8273243: Fix indentations in java.net.InetAddress methods

2021-09-01 Thread Brian Burkhalter
On Wed, 1 Sep 2021 16:53:50 GMT, Aleksei Efimov wrote: > Hi, > > The fix changes indentations in the following `java.net.InetAddress` methods: > - getAddressesFromNameService > - getHostFromNameService > > It helps to improve code readability. Can't say the same about > `getHostFromNameService