Re: RFR: 8268294: Reusing HttpClient in a WebSocket.Listener hangs. [v4]

2021-06-16 Thread Daniel Fuchs
On Wed, 16 Jun 2021 12:07:25 GMT, Michael McMahon wrote: >> Hi, >> >> This fixes a problem where the listener methods of a WebSocket client were >> being invoked by the Selector manager thread, which is problematic, because >> if the implementation of any of these methods tries to do any block

Re: RFR: 8268294: Reusing HttpClient in a WebSocket.Listener hangs. [v4]

2021-06-16 Thread Michael McMahon
> Hi, > > This fixes a problem where the listener methods of a WebSocket client were > being invoked by the Selector manager thread, which is problematic, because > if the implementation of any of these methods tries to do any blocking work, > this impacts other http activity, and if the blocki

Re: RFR: 8268294: Reusing HttpClient in a WebSocket.Listener hangs. [v3]

2021-06-16 Thread Daniel Fuchs
On Wed, 16 Jun 2021 11:24:43 GMT, Michael McMahon wrote: >> Hi, >> >> This fixes a problem where the listener methods of a WebSocket client were >> being invoked by the Selector manager thread, which is problematic, because >> if the implementation of any of these methods tries to do any block

Re: RFR: 8268294: Reusing HttpClient in a WebSocket.Listener hangs. [v3]

2021-06-16 Thread Michael McMahon
> Hi, > > This fixes a problem where the listener methods of a WebSocket client were > being invoked by the Selector manager thread, which is problematic, because > if the implementation of any of these methods tries to do any blocking work, > this impacts other http activity, and if the blocki

Re: RFR: 8268294: Reusing HttpClient in a WebSocket.Listener hangs. [v2]

2021-06-16 Thread Michael McMahon
> Hi, > > This fixes a problem where the listener methods of a WebSocket client were > being invoked by the Selector manager thread, which is problematic, because > if the implementation of any of these methods tries to do any blocking work, > this impacts other http activity, and if the blocki

Re: RFR: 8268294: Reusing HttpClient in a WebSocket.Listener hangs.

2021-06-16 Thread Daniel Fuchs
On Wed, 16 Jun 2021 09:37:22 GMT, Michael McMahon wrote: >> test/jdk/java/net/httpclient/websocket/java.net.http/jdk/internal/net/http/websocket/WebSocketAndHttpClient.java >> line 38: >> >>> 36: HttpTest httpTest = new HttpTest(httpClient, args[1]); >>> 37: >>> 38: AtomicRefer

Re: RFR: 8268294: Reusing HttpClient in a WebSocket.Listener hangs.

2021-06-16 Thread Michael McMahon
On Wed, 16 Jun 2021 09:07:49 GMT, Daniel Fuchs wrote: >> Hi, >> >> This fixes a problem where the listener methods of a WebSocket client were >> being invoked by the Selector manager thread, which is problematic, because >> if the implementation of any of these methods tries to do any blocking

Re: RFR: 8268294: Reusing HttpClient in a WebSocket.Listener hangs.

2021-06-16 Thread Daniel Fuchs
On Wed, 16 Jun 2021 07:56:11 GMT, Michael McMahon wrote: > Hi, > > This fixes a problem where the listener methods of a WebSocket client were > being invoked by the Selector manager thread, which is problematic, because > if the implementation of any of these methods tries to do any blocking w