On Thu, 18 Mar 2021 17:02:57 GMT, Alex Blewitt
wrote:
>> Sonar displays a warning message that modifiers should be declared in the
>> order listed in the JLS; specifically, that isntead of using `final static`
>> the `static final` should be preferred.
>>
>> This fixes the issues in the `java
On Thu, 18 Mar 2021 17:06:04 GMT, Alex Blewitt
wrote:
>>> If I have other fixes for different modules, should I file PRs with the
>>> same bug number e.g. "8263658: Use the blessed modifier order in
>>> java.logging/java.desktop" or should we have separate bug numbers for them?
>>
>> Separate
On Thu, 18 Mar 2021 17:03:28 GMT, Claes Redestad wrote:
>> If I have other fixes for different modules, should I file PRs with the same
>> bug number e.g. "8263658: Use the blessed modifier order in
>> java.logging/java.desktop" or should we have separate bug numbers for them?
>
>> If I have ot
On Thu, 18 Mar 2021 16:51:35 GMT, Alex Blewitt
wrote:
> If I have other fixes for different modules, should I file PRs with the same
> bug number e.g. "8263658: Use the blessed modifier order in
> java.logging/java.desktop" or should we have separate bug numbers for them?
Separate bug numbers
On Thu, 18 Mar 2021 16:50:39 GMT, Claes Redestad wrote:
>> Is that there to indicate a placeholder value that was once used and is kept
>> for documentation purposes? Should the corresponding JavaDoc be removed as
>> well? Should I do this in the same commit/PR as this one, or submit a new
>>
> Sonar displays a warning message that modifiers should be declared in the
> order listed in the JLS; specifically, that isntead of using `final static`
> the `static final` should be preferred.
>
> This fixes the issues in the `java.base` package for ease of reviewing.
>
> https://sonarcloud.