Re: RFR: 8255758: JEP 380 spec clarifications [v3]

2020-11-17 Thread Alan Bateman
On Tue, 17 Nov 2020 11:53:14 GMT, Michael McMahon wrote: >> Minor spec changes from spec approved in initial CSR > > Michael McMahon has updated the pull request incrementally with two > additional commits since the last revision: > > - update from Alan's comment Nov 17 > - minor change sugge

Re: RFR: 8255758: JEP 380 spec clarifications [v2]

2020-11-17 Thread Michael McMahon
On Tue, 17 Nov 2020 11:25:22 GMT, Alan Bateman wrote: >> Michael McMahon has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> comm

Re: RFR: 8255758: JEP 380 spec clarifications [v3]

2020-11-17 Thread Michael McMahon
> Minor spec changes from spec approved in initial CSR Michael McMahon has updated the pull request incrementally with two additional commits since the last revision: - update from Alan's comment Nov 17 - minor change suggested by Daniel - Changes: - all: https://git.openjdk.ja

Re: RFR: 8255758: JEP 380 spec clarifications [v2]

2020-11-17 Thread Alan Bateman
On Mon, 16 Nov 2020 13:29:26 GMT, Michael McMahon wrote: >> Minor spec changes from spec approved in initial CSR > > Michael McMahon has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/

Re: RFR: 8255758: JEP 380 spec clarifications [v2]

2020-11-16 Thread Michael McMahon
On Mon, 16 Nov 2020 14:42:02 GMT, Daniel Fuchs wrote: >> Michael McMahon has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> comm

Re: RFR: 8255758: JEP 380 spec clarifications [v2]

2020-11-16 Thread Daniel Fuchs
On Mon, 16 Nov 2020 13:29:26 GMT, Michael McMahon wrote: >> Minor spec changes from spec approved in initial CSR > > Michael McMahon has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/

Re: RFR: 8255758: JEP 380 spec clarifications [v2]

2020-11-16 Thread Michael McMahon
On Sun, 15 Nov 2020 08:32:28 GMT, Alan Bateman wrote: > The clarification to the SecurityException looks good. > > The API docs specify that bind(null) will "bind to an automatically assigned > socket address". Would it be better to lead with that phrase in the > properties doc rather than swi

Re: RFR: 8255758: JEP 380 spec clarifications [v2]

2020-11-16 Thread Michael McMahon
> Minor spec changes from spec approved in initial CSR Michael McMahon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since th

Re: RFR: 8255758: JEP 380 spec clarifications

2020-11-15 Thread Alan Bateman
On Tue, 3 Nov 2020 14:53:16 GMT, Daniel Fuchs wrote: >> Minor spec changes from spec approved in initial CSR > > Marked as reviewed by dfuchs (Reviewer). The clarification to the SecurityException looks good. The API docs specify that bind(null) will "bind to an automatically assigned socket a

Re: RFR: 8255758: JEP 380 spec clarifications

2020-11-05 Thread Daniel Fuchs
On Mon, 2 Nov 2020 22:04:56 GMT, Michael McMahon wrote: > Minor spec changes from spec approved in initial CSR Marked as reviewed by dfuchs (Reviewer). src/java.base/share/classes/java/net/doc-files/net-properties.html line 250: > 248: Automatic binding of a server socket occurs when {@link >

Re: RFR: 8255758: JEP 380 spec clarifications

2020-11-05 Thread Daniel Fuchs
On Tue, 3 Nov 2020 09:29:54 GMT, Michael McMahon wrote: >> No, an empty path signifies an unnamed address and only client sockets >> (SocketChannels) are allowed to be unnamed. > > You get a BindException if you try to bind a ServerSocketChannel to the > unnamed address. But, the exception mess

Re: RFR: 8255758: JEP 380 spec clarifications

2020-11-05 Thread Michael McMahon
On Tue, 3 Nov 2020 09:25:52 GMT, Michael McMahon wrote: >> src/java.base/share/classes/java/net/doc-files/net-properties.html line 250: >> >>> 248: Automatic binding of a server socket occurs when {@link >>> 249: java.nio.channels.ServerSocketChannel#bind(SocketAddress,int) >>> ServerSocketCha

Re: RFR: 8255758: JEP 380 spec clarifications

2020-11-05 Thread Michael McMahon
On Tue, 3 Nov 2020 09:09:18 GMT, Daniel Fuchs wrote: >> Minor spec changes from spec approved in initial CSR > > src/java.base/share/classes/java/net/doc-files/net-properties.html line 246: > >> 244: Unix domain sockets >> 245: There are a number of system (and networking) properties that affect

Re: RFR: 8255758: JEP 380 spec clarifications

2020-11-05 Thread Daniel Fuchs
On Tue, 3 Nov 2020 09:21:05 GMT, Michael McMahon wrote: >> src/java.base/share/classes/java/net/doc-files/net-properties.html line 246: >> >>> 244: Unix domain sockets >>> 245: There are a number of system (and networking) properties that >>> affect the behavior of >>> 246: channels to Unix dom

Re: RFR: 8255758: JEP 380 spec clarifications

2020-11-05 Thread Michael McMahon
On Tue, 3 Nov 2020 09:42:05 GMT, Daniel Fuchs wrote: >> I'm not sure, as the system properties don't affect implicit binding, but I >> would have liked to have a place to "explain" all aspects of binding of Unix >> domain sockets/server-sockets. Maybe, I could add a paragraph at the end, >> ju