Re: RFR: 8255675: Typo in java.net.HttpURLConnection

2020-11-23 Thread Julia Boes
On Mon, 23 Nov 2020 11:01:35 GMT, Michael McMahon wrote: > What is the effect if this change is integrated as is (from the master > branch)? The normal procedure is to merge from a separate branch. @anupamdev20 note the bot comment above, pushing from your master branch will diverge it. You ca

Re: RFR: 8255675: Typo in java.net.HttpURLConnection

2020-11-23 Thread Michael McMahon
On Mon, 23 Nov 2020 10:44:12 GMT, Chris Hegarty wrote: >> 8255675: Typo in java.net.HttpURLConnection > > Marked as reviewed by chegar (Reviewer). What is the effect if this change is integrated as is (from the master branch)? The normal procedure is to merge from a separate branch. --

Re: RFR: 8255675: Typo in java.net.HttpURLConnection

2020-11-23 Thread Chris Hegarty
On Tue, 17 Nov 2020 07:50:10 GMT, ANUPAM DEV wrote: > 8255675: Typo in java.net.HttpURLConnection Marked as reviewed by chegar (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/1250

Re: RFR: 8255675: Typo in java.net.HttpURLConnection

2020-11-17 Thread ANUPAM DEV
On Tue, 17 Nov 2020 07:50:10 GMT, ANUPAM DEV wrote: > 8255675: Typo in java.net.HttpURLConnection Hello All, Could you please review this fix? Bug: https://bugs.openjdk.java.net/browse/JDK-8255675 Problem description: In the getResponseCode method, the following comment was unclear: "If we