Re: RFR: 8253470: Javadoc clean up in Filter and Headers [v5]

2020-10-02 Thread Michael McMahon
On Fri, 2 Oct 2020 08:52:53 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my doc-only fix for JDK-8253470 - 'Javadoc clean >> up in Filter and Headers' ? >> >> This fix is set of formatting changes intended to clean up the javadoc of >> the following classes : >> >>

Re: RFR: 8253470: Javadoc clean up in Filter and Headers [v4]

2020-10-02 Thread Patrick Concannon
On Thu, 1 Oct 2020 15:43:44 GMT, Daniel Fuchs wrote: >> src/jdk.httpserver/share/classes/com/sun/net/httpserver/Filter.java line 40: >> >>> 38: * are organised in chains, and are associated with {@link HttpContext} >>> instances. >>> 39: * >>> 40: * Each {@Filter} in the chain, invokes the

Re: RFR: 8253470: Javadoc clean up in Filter and Headers [v5]

2020-10-02 Thread Daniel Fuchs
On Fri, 2 Oct 2020 08:52:53 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my doc-only fix for JDK-8253470 - 'Javadoc clean >> up in Filter and Headers' ? >> >> This fix is set of formatting changes intended to clean up the javadoc of >> the following classes : >> >>

Re: RFR: 8253470: Javadoc clean up in Filter and Headers [v5]

2020-10-02 Thread Patrick Concannon
> Hi, > > Could someone please review my doc-only fix for JDK-8253470 - 'Javadoc clean > up in Filter and Headers' ? > > This fix is set of formatting changes intended to clean up the javadoc of the > following classes : > > `com.sun.net.httpserver.Filter` > `com.sun.net.httpserver.Filter.Chai

Re: RFR: 8253470: Javadoc clean up in Filter and Headers [v4]

2020-10-01 Thread Daniel Fuchs
On Thu, 1 Oct 2020 14:27:10 GMT, Michael McMahon wrote: >> Patrick Concannon has updated the pull request with a new target base due to >> a merge or a rebase. The incremental >> webrev excludes the unrelated changes brought in by the merge/rebase. The >> pull request contains four additional c

Re: RFR: 8253470: Javadoc clean up in Filter and Headers [v4]

2020-10-01 Thread Daniel Fuchs
On Thu, 1 Oct 2020 12:03:04 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my doc-only fix for JDK-8253470 - 'Javadoc clean >> up in Filter and Headers' ? >> >> This fix is set of formatting changes intended to clean up the javadoc of >> the following classes : >> >>

Re: RFR: 8253470: Javadoc clean up in Filter and Headers [v4]

2020-10-01 Thread Michael McMahon
On Thu, 1 Oct 2020 12:03:04 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my doc-only fix for JDK-8253470 - 'Javadoc clean >> up in Filter and Headers' ? >> >> This fix is set of formatting changes intended to clean up the javadoc of >> the following classes : >> >>

Re: RFR: 8253470: Javadoc clean up in Filter and Headers [v4]

2020-10-01 Thread Daniel Fuchs
On Thu, 1 Oct 2020 12:03:04 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my doc-only fix for JDK-8253470 - 'Javadoc clean >> up in Filter and Headers' ? >> >> This fix is set of formatting changes intended to clean up the javadoc of >> the following classes : >> >>

Re: RFR: 8253470: Javadoc clean up in Filter and Headers [v4]

2020-10-01 Thread Patrick Concannon
On Wed, 30 Sep 2020 10:31:29 GMT, Michael McMahon wrote: >> Patrick Concannon has updated the pull request with a new target base due to >> a merge or a rebase. The incremental >> webrev excludes the unrelated changes brought in by the merge/rebase. The >> pull request contains four additional

Re: RFR: 8253470: Javadoc clean up in Filter and Headers [v4]

2020-10-01 Thread Patrick Concannon
On Wed, 30 Sep 2020 10:21:22 GMT, Daniel Fuchs wrote: >> Patrick Concannon has updated the pull request with a new target base due to >> a merge or a rebase. The incremental >> webrev excludes the unrelated changes brought in by the merge/rebase. The >> pull request contains four additional com

Re: RFR: 8253470: Javadoc clean up in Filter and Headers [v4]

2020-10-01 Thread Patrick Concannon
> Hi, > > Could someone please review my doc-only fix for JDK-8253470 - 'Javadoc clean > up in Filter and Headers' ? > > This fix is set of formatting changes intended to clean up the javadoc of the > following classes : > > `com.sun.net.httpserver.Filter` > `com.sun.net.httpserver.Filter.Chai

Re: RFR: 8253470: Javadoc clean up in Filter and Headers [v3]

2020-10-01 Thread Patrick Concannon
> Hi, > > Could someone please review my doc-only fix for JDK-8253470 - 'Javadoc clean > up in Filter and Headers' ? > > This fix is set of formatting changes intended to clean up the javadoc of the > following classes : > > `com.sun.net.httpserver.Filter` > `com.sun.net.httpserver.Filter.Chai

Re: RFR: 8253470: Javadoc clean up in Filter and Headers [v2]

2020-09-30 Thread Patrick Concannon
> Hi, > > Could someone please review my doc-only fix for JDK-8253470 - 'Javadoc clean > up in Filter and Headers' ? > > This fix is set of formatting changes intended to clean up the javadoc of the > following classes : > > `com.sun.net.httpserver.Filter` > `com.sun.net.httpserver.Filter.Chai

Re: RFR: 8253470: Javadoc clean up in Filter and Headers

2020-09-30 Thread Michael McMahon
On Wed, 30 Sep 2020 10:02:06 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my doc-only fix for JDK-8253470 - 'Javadoc clean > up in Filter and Headers' ? > > This fix is set of formatting changes intended to clean up the javadoc of the > following classes : > > `com.su

Re: RFR: 8253470: Javadoc clean up in Filter and Headers

2020-09-30 Thread Daniel Fuchs
On Wed, 30 Sep 2020 10:02:06 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my doc-only fix for JDK-8253470 - 'Javadoc clean > up in Filter and Headers' ? > > This fix is set of formatting changes intended to clean up the javadoc of the > following classes : > > `com.su