Re: RFR: 8252837: Cleanup SAP Copyright file headers

2020-09-07 Thread Christoph Langer
On Mon, 7 Sep 2020 07:27:39 GMT, Christoph Langer wrote: >> Marked as reviewed by dholmes (Reviewer). > >> _Mailing list message from [David Holmes](mailto:david.hol...@oracle.com) on >> [nio-dev](mailto:nio-...@openjdk.java.net):_ >> Looks good to me - and trivial. >> >> Thanks, >> David >> >>

Re: RFR: 8252837: Cleanup SAP Copyright file headers

2020-09-07 Thread David Holmes
On Mon, 7 Sep 2020 04:14:06 GMT, Christoph Langer wrote: > The format for SAP copyrights in OpenJDK headers should be like: > Copyright (c) SAP SE. All rights reserved. > or > Copyright (c) , SAP SE. All rights reserved. > > There should not be a comma character (",") before "SAP SE". > > Thi

Re: RFR: 8252837: Cleanup SAP Copyright file headers

2020-09-07 Thread David Holmes
On Mon, 7 Sep 2020 07:28:36 GMT, Christoph Langer wrote: >>> _Mailing list message from [David Holmes](mailto:david.hol...@oracle.com) on >>> [nio-dev](mailto:nio-...@openjdk.java.net):_ >>> Looks good to me - and trivial. >>> >>> Thanks, >>> David >>> >>> On 7/09/2020 2:22 pm, Christoph Langer

Re: RFR: 8252837: Cleanup SAP Copyright file headers

2020-09-07 Thread Christoph Langer
On Mon, 7 Sep 2020 07:25:41 GMT, David Holmes wrote: >> The format for SAP copyrights in OpenJDK headers should be like: >> Copyright (c) SAP SE. All rights reserved. >> or >> Copyright (c) , SAP SE. All rights reserved. >> >> There should not be a comma character (",") before "SAP SE". >> >>

Re: RFR: 8252837: Cleanup SAP Copyright file headers

2020-09-07 Thread David Holmes
Looks good to me - and trivial. Thanks, David On 7/09/2020 2:22 pm, Christoph Langer wrote: The format for SAP copyrights in OpenJDK headers should be like: Copyright (c) SAP SE. All rights reserved. or Copyright (c) , SAP SE. All rights reserved. There should not be a comma character (",")

RE: RFR: 8252837: Cleanup SAP Copyright file headers

2020-09-06 Thread Lindenmaier, Goetz
Hi Christoph, Looks good to me 😊 Best regards, Goetz. -Original Message- From: nio-dev On Behalf Of Christoph Langer Sent: Montag, 7. September 2020 06:22 To: hotspot-...@openjdk.java.net; net-dev@openjdk.java.net; nio-...@openjdk.java.net; serviceability-...@openjdk.java.net Subjec