Re: RFR: 8245194: Unix domain socket channel implementation [v35]

2020-10-28 Thread Michael McMahon
On Sat, 24 Oct 2020 08:12:57 GMT, Alan Bateman wrote: >> Michael McMahon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> - fixed 32 bit Linux build error >> - test updates from Chris > > src/java.base/windows/classes/sun/nio/ch/Windows

Re: RFR: 8245194: Unix domain socket channel implementation [v35]

2020-10-24 Thread Alan Bateman
On Thu, 22 Oct 2020 08:14:31 GMT, Michael McMahon wrote: >> Continuing this review as a PR on github with the comments below >> incorporated. I expect there will be a few more iterations before >> integrating. >> >> On 06/09/2020 19:47, Alan Bateman wrote: >>> On 26/08/2020 15:24, Michael McMa

Re: RFR: 8245194: Unix domain socket channel implementation [v35]

2020-10-22 Thread Chris Hegarty
On Thu, 22 Oct 2020 08:14:31 GMT, Michael McMahon wrote: >> Continuing this review as a PR on github with the comments below >> incorporated. I expect there will be a few more iterations before >> integrating. >> >> On 06/09/2020 19:47, Alan Bateman wrote: >>> On 26/08/2020 15:24, Michael McMa

Re: RFR: 8245194: Unix domain socket channel implementation [v35]

2020-10-22 Thread Michael McMahon
> Continuing this review as a PR on github with the comments below > incorporated. I expect there will be a few more iterations before integrating. > > On 06/09/2020 19:47, Alan Bateman wrote: >> On 26/08/2020 15:24, Michael McMahon wrote: >>> >>> As I mentioned the other day, I wasn't able to us