Re: RFR: 8245194: Unix domain socket channel implementation [v20]

2020-10-14 Thread Michael McMahon
On Wed, 14 Oct 2020 14:21:13 GMT, Daniel Fuchs wrote: >> Michael McMahon has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev >> excludes the unrelated changes brought in by the merge/rebase. The pull >> request contains 22 additional commits

Re: RFR: 8245194: Unix domain socket channel implementation [v20]

2020-10-14 Thread Michael McMahon
On Wed, 14 Oct 2020 14:14:48 GMT, Daniel Fuchs wrote: >> Michael McMahon has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev >> excludes the unrelated changes brought in by the merge/rebase. The pull >> request contains 22 additional commits

Re: RFR: 8245194: Unix domain socket channel implementation [v20]

2020-10-14 Thread Michael McMahon
On Wed, 14 Oct 2020 13:56:42 GMT, Daniel Fuchs wrote: >> Michael McMahon has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev >> excludes the unrelated changes brought in by the merge/rebase. The pull >> request contains 22 additional commits

Re: RFR: 8245194: Unix domain socket channel implementation [v20]

2020-10-14 Thread Michael McMahon
On Wed, 14 Oct 2020 12:28:04 GMT, Daniel Fuchs wrote: >> Michael McMahon has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev >> excludes the unrelated changes brought in by the merge/rebase. The pull >> request contains 22 additional commits

Re: RFR: 8245194: Unix domain socket channel implementation [v20]

2020-10-14 Thread Michael McMahon
On Wed, 14 Oct 2020 12:24:11 GMT, Daniel Fuchs wrote: >> Michael McMahon has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev >> excludes the unrelated changes brought in by the merge/rebase. The pull >> request contains 22 additional commits

Re: RFR: 8245194: Unix domain socket channel implementation [v20]

2020-10-14 Thread Michael McMahon
On Wed, 14 Oct 2020 13:17:01 GMT, Michael McMahon wrote: >> src/java.base/share/classes/sun/net/ext/ExtendedSocketOptions.java line 63: >> >>> 61: /** Return the, possibly empty, set of extended socket options >>> available. */ >>> 62: public final Set> unixOptions() { return >>> unixO

Re: RFR: 8245194: Unix domain socket channel implementation [v20]

2020-10-14 Thread Michael McMahon
On Wed, 14 Oct 2020 11:19:59 GMT, Daniel Fuchs wrote: >> Michael McMahon has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev >> excludes the unrelated changes brought in by the merge/rebase. The pull >> request contains 22 additional commits

Re: RFR: 8245194: Unix domain socket channel implementation [v20]

2020-10-14 Thread Daniel Fuchs
On Tue, 13 Oct 2020 19:09:44 GMT, Michael McMahon wrote: >> Continuing this review as a PR on github with the comments below >> incorporated. I expect there will be a few more >> iterations before integrating. >> On 06/09/2020 19:47, Alan Bateman wrote: >>> On 26/08/2020 15:24, Michael McMahon w

Re: RFR: 8245194: Unix domain socket channel implementation [v20]

2020-10-14 Thread Michael McMahon
On Wed, 14 Oct 2020 11:37:09 GMT, Daniel Fuchs wrote: >> Michael McMahon has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev >> excludes the unrelated changes brought in by the merge/rebase. The pull >> request contains 22 additional commits

Re: RFR: 8245194: Unix domain socket channel implementation [v20]

2020-10-14 Thread Michael McMahon
On Wed, 14 Oct 2020 11:04:08 GMT, Daniel Fuchs wrote: >> Michael McMahon has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev >> excludes the unrelated changes brought in by the merge/rebase. The pull >> request contains 22 additional commits

Re: RFR: 8245194: Unix domain socket channel implementation [v20]

2020-10-14 Thread Daniel Fuchs
On Tue, 13 Oct 2020 19:09:44 GMT, Michael McMahon wrote: >> Continuing this review as a PR on github with the comments below >> incorporated. I expect there will be a few more >> iterations before integrating. >> On 06/09/2020 19:47, Alan Bateman wrote: >>> On 26/08/2020 15:24, Michael McMahon w

Re: RFR: 8245194: Unix domain socket channel implementation [v20]

2020-10-13 Thread Michael McMahon
> Continuing this review as a PR on github with the comments below > incorporated. I expect there will be a few more > iterations before integrating. > On 06/09/2020 19:47, Alan Bateman wrote: >> On 26/08/2020 15:24, Michael McMahon wrote: >>> >>> As I mentioned the other day, I wasn't able to use