Re: RFR: 8245194: Unix domain socket channel implementation [v14]

2020-10-13 Thread Michael McMahon
On Mon, 12 Oct 2020 11:02:12 GMT, Michael McMahon wrote: >> Thanks again Alan. Assume where there is no comment from me below that >> suggestions are accepted: >> I will push an update based on these changes soon. >> >> Michael. >> >>> _Mailing list message from [Alan Bateman](mailto:alan.bate

Re: RFR: 8245194: Unix domain socket channel implementation [v14]

2020-10-12 Thread Michael McMahon
On Mon, 5 Oct 2020 15:09:53 GMT, Michael McMahon wrote: >> Build changes look good. > > Thanks again Alan. Assume where there is no comment from me below that > suggestions are accepted: > I will push an update based on these changes soon. > > Michael. > >> _Mailing list message from [Alan Bat

Re: RFR: 8245194: Unix domain socket channel implementation [v14]

2020-10-05 Thread Michael McMahon
On Mon, 5 Oct 2020 12:58:52 GMT, Erik Joelsson wrote: >> Michael McMahon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> - simplified Copy.gmk to CAT source files directly >> - renamed net.properties source files to all be net.properti

Re: RFR: 8245194: Unix domain socket channel implementation [v14]

2020-10-05 Thread Erik Joelsson
On Sun, 4 Oct 2020 13:14:49 GMT, Michael McMahon wrote: >> Continuing this review as a PR on github with the comments below >> incorporated. I expect there will be a few more >> iterations before integrating. >> On 06/09/2020 19:47, Alan Bateman wrote: >>> On 26/08/2020 15:24, Michael McMahon wr

Re: RFR: 8245194: Unix domain socket channel implementation [v14]

2020-10-04 Thread Michael McMahon
> Continuing this review as a PR on github with the comments below > incorporated. I expect there will be a few more > iterations before integrating. > On 06/09/2020 19:47, Alan Bateman wrote: >> On 26/08/2020 15:24, Michael McMahon wrote: >>> >>> As I mentioned the other day, I wasn't able to use