Will do.
Thanks Chris
Kind regards,
Patrick
On 07/08/2019 12:35, Chris Hegarty wrote:
Patrick,
On 07/08/2019 11:42, Daniel Fuchs wrote:
On 07/08/2019 11:22, Patrick Concannon wrote:
Hi,
Please find a link to the updated webrev below:
http://cr.openjdk.java.net/~dfuchs/pconcann/8228970/w
Patrick,
On 07/08/2019 11:42, Daniel Fuchs wrote:
On 07/08/2019 11:22, Patrick Concannon wrote:
Hi,
Please find a link to the updated webrev below:
http://cr.openjdk.java.net/~dfuchs/pconcann/8228970/webrevs/webrev.3/
Looks good.
Trivially, before you push, in the test can you please put a
On 07/08/2019 11:22, Patrick Concannon wrote:
Hi,
Please find a link to the updated webrev below:
http://cr.openjdk.java.net/~dfuchs/pconcann/8228970/webrevs/webrev.3/
That looks good to me Patrick!
I agree that the test code looks cleaner this way.
best regards,
-- daniel
Kind regards,
Hi,
Please find a link to the updated webrev below:
http://cr.openjdk.java.net/~dfuchs/pconcann/8228970/webrevs/webrev.3/
Kind regards,
Patrick
On 06/08/2019 12:08, Patrick Concannon wrote:
Hi,
Thanks for the feedback, Pavel. I'll make that switch now!
Kind regards,
Patrick
On 06/08/20
Hi,
Thanks for the feedback, Pavel. I'll make that switch now!
Kind regards,
Patrick
On 06/08/2019 11:31, Pavel Rappo wrote:
May I suggest using org.testng.Assert.assertThrows instead of hand-rolled
try-catch constructs in the test?
On 6 Aug 2019, at 11:12, Patrick Concannon wrote:
Hi,
W
May I suggest using org.testng.Assert.assertThrows instead of hand-rolled
try-catch constructs in the test?
> On 6 Aug 2019, at 11:12, Patrick Concannon
> wrote:
>
> Hi,
>
> Would it be possible to have my fix for JDK-8228970 reviewed?
>
> The fix modifies the read(byte[], int, int) method fr
