On 24/01/2019, 14:38, Alan Bateman wrote:
On 24/01/2019 13:09, Michael McMahon wrote:
I've updated the webrev at
http://cr.openjdk.java.net/~michaelm/8216986/webrev.2/
to add some tests and also I found the same dubious implementation of
getLocalPort()
in HttpConnectSocketImpl.java. The test
On 24/01/2019 13:09, Michael McMahon wrote:
I've updated the webrev at
http://cr.openjdk.java.net/~michaelm/8216986/webrev.2/
to add some tests and also I found the same dubious implementation of
getLocalPort()
in HttpConnectSocketImpl.java. The test infrastructure needed some
cleanup also.
Th
I've updated the webrev at
http://cr.openjdk.java.net/~michaelm/8216986/webrev.2/
to add some tests and also I found the same dubious implementation of
getLocalPort()
in HttpConnectSocketImpl.java. The test infrastructure needed some
cleanup also.
Thanks,
Michael.
On 23/01/2019, 14:30, Micha
On 23/01/2019, 12:37, Alan Bateman wrote:
On 23/01/2019 11:44, Michael McMahon wrote:
Hi
Could I get the following webrev reviewed please?
It is just to remove dead code from SocksSocketImpl.
Most of the code was an (unused) attempt to implement
SOCKS for ServerSockets. getLocalPort() was po
On 23/01/2019 11:44, Michael McMahon wrote:
Hi
Could I get the following webrev reviewed please?
It is just to remove dead code from SocksSocketImpl.
Most of the code was an (unused) attempt to implement
SOCKS for ServerSockets. getLocalPort() was potentially buggy
and should not override the su
