On 2018-12-13 14:06, Daniel Fuchs wrote:
Looks good Claes!
Thanks!
I eyeballed the rest of the patch and found
nothing wrong - but with a patch this size
it would be easy to miss something.
Yes, I've gone through it a couple of times now
to be sure.
Were you able to measure any improveme
Looks good Claes!
I eyeballed the rest of the patch and found
nothing wrong - but with a patch this size
it would be easy to miss something.
Were you able to measure any improvement after
patching?
best regards,
-- daniel
On 12/12/2018 17:06, Claes Redestad wrote:
On 2018-12-12 17:54, Dani
On 2018-12-12 17:54, Daniel Fuchs wrote:
Hi Claes,
It might read even better if things like:
+ resultString = !specarg.isEmpty() ? specarg.intern(): opt;
were changed into:
+ resultString = specarg.isEmpty() ? opt : specarg.intern();
best regards,
I only found this pattern
On 2018-12-12 17:56, Alan Bateman wrote:
In Checks.java, the parameter change from CharSequence to String means
that "cs" needs to be renamed.
Changed to 'str'
/Claes
On 12/12/2018 16:53, Claes Redestad wrote:
Hi,
please review this patch to use String.isEmpty when applicable:
Webrev: http://cr.openjdk.java.net/~redestad/8215281/jdk.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8215281
Why?
- It reads better :-)
- Better startup/warmup due fewer method
Hi Claes,
It might read even better if things like:
+resultString = !specarg.isEmpty() ? specarg.intern(): opt;
were changed into:
+resultString = specarg.isEmpty() ? opt : specarg.intern();
best regards,
-- daniel
On 12/12/2018 16:53, Claes Redestad wrote:
Hi,
please revi
